DrJava Legacy SVN Repository

Added "local-release", "local-release-beta" and "local-release-stable"
Ant targets, as suggested by Corky in class today. They automatically
set the "skip-tag" property, so you do not need to specify -Dskip-tag=true
on the command line anymore.
Changed the description of the regular "release*" targets to clarify
that they create Subversion tags.

This revision cleans up the code managing the interactions pane,
particularly the updating of the cursor, which was handled abominably
in earlier versions. The key insight in this refactoring is that the
interactions pane is tightly coupled with the interactions document.
In Swing, documents do not include any viewing state, most notably the
cursor position. But in an interactions pane, the position of the
cursor is a critical feature of the document an must be kept updated
by operations on the cdocument (such as console output, e.g.,
System.out, by the interpreter). Since the cursor resides in the
interactions pane, the interactions model must fuse the pane and the
document together. To keep the cursor in synch with all updates to the
interactions document, the refactored code base forces all interactions
document updates to be performed in the event thread. Then model operations
that do not originate with Swing components (such as console output by the
interpreter) can update the cursor before any Swing based updates (e.g.,
keyboard input) happen. In the old code, every document revision fired a
document listener that updated the cursor position in the interactions pane,
possibly from outside the event thread, breaking a critical Swing invariant.
(In particular, console output by the interpreter interspersed with keyboard
input would corrupt Swing/DrJava data structures.

This revision also excises the ConsoleControllerTest since it tested console
behavior (processing keyboard input) that is no longer possible in DrJava;
InteractionsConsoleController now handles all keyboard input. The code tested
by ConsoleControllerTest has also been removed.

The following files were modified:

M src/edu/rice/cs/drjava/DrJavaTestCase.java
M src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDocument.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDocumentTest.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDJDocumentTest.java
M src/edu/rice/cs/drjava/model/repl/InteractionsModel.java
M src/edu/rice/cs/drjava/model/repl/newjvm/InterpreterJVM.java
M src/edu/rice/cs/drjava/model/repl/newjvm/MainJVM.java
M src/edu/rice/cs/drjava/model/repl/DefaultInteractionsModel.java
M src/edu/rice/cs/drjava/model/repl/RMIInteractionsModel.java
M src/edu/rice/cs/drjava/model/repl/SimpleInteractionsModel.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/ConsoleController.java
M src/edu/rice/cs/drjava/ui/InteractionsPaneTest.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java
D src/edu/rice/cs/drjava/ui/ConsoleControllerTest.java
M src/edu/rice/cs/drjava/ui/AbstractConsoleController.java
M src/edu/rice/cs/util/text/ConsoleDocument.java

Fix for MacOS and Linux for getting the svn revision.

Deleted accidentally created tag.
D https://drjava.svn.sourceforge.net/svnroot/drjava/tags/drjava-stable-20080323-1343-r4409

Created tag drjava-stable-20080323-1343-r4409

Added revision number to About and Error dialog, and
to end of file names (drjava-stable-20080323-0743-r4409.jar).

Added -Dno-skip=true parameter to perform a release,
release-beta or release-stable without creating a tag
in the subversion repository.

This commit includes some minor changes to the synchronization of
operations in InteractionsDJDocument, InteractionsModel,
AbstractConsoleController, ConsoleController and Interacitons
Controller, which seem to reduced the incidence of synchronization
errors when entering interactions input while a background thread in
the interpreter is continuously generating output (using System.out or
System.err).

The following files were modified:

M src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/BraceInfo.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelControl.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelBrace.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDJDocument.java
M src/edu/rice/cs/drjava/model/repl/InteractionsModel.java
M src/edu/rice/cs/drjava/ui/SimpleInteractionsWindow.java
M src/edu/rice/cs/drjava/ui/ConsoleController.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java
M src/edu/rice/cs/drjava/ui/AbstractConsoleController.java
M src/edu/rice/cs/util/text/ConsoleDocument.java
M src/edu/rice/cs/util/text/ConsoleDocumentTest.java
M src/edu/rice/cs/util/text/SwingDocument.java

This revision is another incremental cleanup of the ReducedModel and AbstractDJDocument code. The following files were modified:

M src/edu/rice/cs/drjava/model/definitions/indent/QuestionStartAfterOpenBrace.java
M src/edu/rice/cs/drjava/model/definitions/indent/QuestionHasCharPrecedingOpenBrace.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelControl.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/ui/ExecuteExternalDialog.java

This commit contains a modest cleanup of some ReducedModel/AbstractDJDocument code. In addition, synchronization is added to the indent keystroke action in DefintionsPane and the construction of the findall panel and document highlights in FindReplacePanel.

The following files were modified:

M src/edu/rice/cs/drjava/model/definitions/indent/QuestionPrevLineStartsComment.java
M src/edu/rice/cs/drjava/model/definitions/indent/QuestionExistsCharInPrevStmt.java
M src/edu/rice/cs/drjava/model/definitions/indent/QuestionCurrLineStartsWithSkipComments.java
M src/edu/rice/cs/drjava/model/definitions/indent/QuestionStartAfterOpenBrace.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelComment.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/AbstractReducedModel.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ModelListTest.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ModelList.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelControl.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/TokenList.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelBrace.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/model/DummyOpenDefDoc.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/DJDocument.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java

This commit corrects a performance bug that I introduced earlier this
year. It eliminates write lock bracketing around the action performed
withn the method _processAllInCurrentDoc on the document corresponding
to the results collection being processed. I had added the write lock bracketing
to accommodate possible modification of the document. But
processAll (which is the only method that calls
_processAllInCurrentDoc) is only passed commands that do not touch the
corresponding DefintionsDocument. I narrowed the contract accordingly
and dropped the write lock bracketing.

The acquireWriteLock() operation forced the current
openDefinitionsDocument to be realized (constructing the virtualized
DefinitionsDocument embedded within).

The following files were modified, most of them incidentally:

M src/edu/rice/cs/drjava/model/GlobalModelIOTest.java
M src/edu/rice/cs/drjava/model/cache/DocumentCache.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/model/FindReplaceMachine.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java
M src/edu/rice/cs/util/text/ConsoleDocument.java
M src/edu/rice/cs/util/text/SwingDocument.java
M src/edu/rice/cs/util/swing/HighlightManager.java