DrJava Legacy SVN Repository

particularly the updating of the cursor, which was handled abominably
in earlier versions. The key insight in this refactoring is that the
interactions pane is tightly coupled with the interactions document.
In Swing, documents do not include any viewing state, most notably the
cursor position. But in an interactions pane, the position of the
cursor is a critical feature of the document an must be kept updated
by operations on the cdocument (such as console output, e.g.,
System.out, by the interpreter). Since the cursor resides in the
interactions pane, the interactions model must fuse the pane and the
document together. To keep the cursor in synch with all updates to the
interactions document, the refactored code base forces all interactions
document updates to be performed in the event thread. Then model operations
that do not originate with Swing components (such as console output by the
interpreter) can update the cursor before any Swing based updates (e.g.,
keyboard input) happen. In the old code, every document revision fired a
document listener that updated the cursor position in the interactions pane,
possibly from outside the event thread, breaking a critical Swing invariant.
(In particular, console output by the interpreter interspersed with keyboard
input would corrupt Swing/DrJava data structures.

This revision also excises the ConsoleControllerTest since it tested console
behavior (processing keyboard input) that is no longer possible in DrJava;
InteractionsConsoleController now handles all keyboard input. The code tested
by ConsoleControllerTest has also been removed.

The following files were modified:

M src/edu/rice/cs/drjava/DrJavaTestCase.java
M src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDocument.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDocumentTest.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDJDocumentTest.java
M src/edu/rice/cs/drjava/model/repl/InteractionsModel.java
M src/edu/rice/cs/drjava/model/repl/newjvm/InterpreterJVM.java
M src/edu/rice/cs/drjava/model/repl/newjvm/MainJVM.java
M src/edu/rice/cs/drjava/model/repl/DefaultInteractionsModel.java
M src/edu/rice/cs/drjava/model/repl/RMIInteractionsModel.java
M src/edu/rice/cs/drjava/model/repl/SimpleInteractionsModel.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/ConsoleController.java
M src/edu/rice/cs/drjava/ui/InteractionsPaneTest.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java
D src/edu/rice/cs/drjava/ui/ConsoleControllerTest.java
M src/edu/rice/cs/drjava/ui/AbstractConsoleController.java
M src/edu/rice/cs/util/text/ConsoleDocument.java