DrJava Legacy SVN Repository

This revision is a minor cleanup of the code in InteractionsController.

Cleaned up the code in InteractionsController supporting console input
within the interactions pane. The following files were updates
(changes to files other than InteractionsController were cosmetic).

M src/edu/rice/cs/drjava/model/repl/InteractionsDJDocument.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java
M src/edu/rice/cs/util/text/ConsoleDocument.java
M build.xml

This revision further cleans up the coding of synchronization in the
InteractionsController. It also eliminates the CodeStatus.DEVELOPMENT
references in the code which evidently only enabled anti-aliasing in
development builds. The following classes were modified:

M src/edu/rice/cs/drjava/model/repl/InteractionsModel.java
M src/edu/rice/cs/drjava/model/repl/DefaultInteractionsModel.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/HelpFrame.java
M src/edu/rice/cs/drjava/ui/InteractionsPane.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/ConsoleController.java
M src/edu/rice/cs/drjava/ui/config/ConfigFrame.java
M src/edu/rice/cs/drjava/ui/RecentDocFrame.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java
M src/edu/rice/cs/util/FileOps.java
M src/edu/rice/cs/util/text/ConsoleDocument.java
M src/edu/rice/cs/util/text/SwingDocument.java

Changed the build.xml script to use the JUnit formatter "oneline"
by default, if it is available. If it isn't, then the standard
"brief" formatter will be used as in the past.
You can change the formatter by using -Djunit-formatter=brief.
or -Djunit-formatter=quiet, etc.
To get the "oneline" and "quiet" formatters, please grab my
modified version of Ant 1.7.0 from
http://www.superscalar.org/files/apache-ant-1.7.0-quiet/

M build.xml

Checks files when opening project to see if they have been modified outside of DrJava. If a file has been modified, clears all of the bookmarks and breakpoints associated with that file.
Also fixed NullPointerException caused by bug [1651914] by adding a test for null.

M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/InteractionsPane.java

This revision eliminates some non-event thread references to
event-thread only methods and fields in the class
IneractionsController. It also updates a test in InteractionsPaneTest
to conform to a revision in the contract for a method only called from
test code. This revision is intended to fix a bug in the handling of
console input in the interactions pane related to bug 1604928, which was
at least partially fixed in revision 4113. The remaining/related bug
throws an ArrayIndexOutOfBoundsException fromm an unknown source (in the
slave JVM?). The following files were updated:

M src/edu/rice/cs/drjava/ui/InteractionsPaneTest.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java

In an attempt to fix bugs #1604928 and #1450321 concerning
non-deterministic timing problems in the use of console input in the
interactions pane, I read the code in AbstractConsoleController.java,
InteractionsConsoleController.java and ConsoleController.java looking
for synchronization errors. I discovered that many apparent shared
fields were not marked either as volatile or final, so I added
volatile or final attributes to all such field declarations and tried
to reproduce the timing problem mentioned in bug #1604928. I did not
succeed.

This change appears to either fix the timing bug or make its
occurrence far less likely. The following files were modified

M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java
M src/edu/rice/cs/drjava/ui/AbstractConsoleController.java
M src/edu/rice/cs/util/swing/AsyncTaskLauncher.java

Changed build.xml to use "quiet" JUnit formatter if available.
If it's not available, it continues to use "brief", and nothing
has changed.
M build.xml

This revision refactors the implementation of getText in
AbstractGlobalModel and OpenDefinitionsDocument to bypass
reconstructing the document when it has been kicked out of the cache.
The revision changes the representation of the document image cached
in the DDReconstructor from a byte array to a String. This may
negatively impact the footprint of large projects. The revision
modified the following file.

M src/edu/rice/cs/drjava/model/cache/DocumentCache.java
M src/edu/rice/cs/drjava/model/cache/DocumentCacheTest.java
M src/edu/rice/cs/drjava/model/cache/DDReconstructor.java
M src/edu/rice/cs/drjava/model/cache/DCacheAdapter.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/FindReplaceMachine.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java

This revision refactors the implementation of getText in
AbstractGlobalModel and OpenDefinitionsDocument to bypass
reconstructing the document when it has been kicked out of the cache.
The revision changes the representation of the document image cached
in the DDReconstructor from a byte array to a String. This may
negatively impact the footprint of large projects. The revision
modified the following file.

M src/edu/rice/cs/drjava/model/cache/DocumentCache.java
M src/edu/rice/cs/drjava/model/cache/DocumentCacheTest.java
M src/edu/rice/cs/drjava/model/cache/DDReconstructor.java
M src/edu/rice/cs/drjava/model/cache/DCacheAdapter.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/FindReplaceMachine.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java