Menu

Commit [r4113]  Maximize  Restore  History

In an attempt to fix bugs #1604928 and #1450321 concerning

non-deterministic timing problems in the use of console input in the
interactions pane, I read the code in AbstractConsoleController.java,
InteractionsConsoleController.java and ConsoleController.java looking
for synchronization errors. I discovered that many apparent shared
fields were not marked either as volatile or final, so I added
volatile or final attributes to all such field declarations and tried
to reproduce the timing problem mentioned in bug #1604928. I did not
succeed.

This change appears to either fix the timing bug or make its
occurrence far less likely. The following files were modified

M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java
M src/edu/rice/cs/drjava/ui/AbstractConsoleController.java
M src/edu/rice/cs/util/swing/AsyncTaskLauncher.java

rcartwright 2007-02-04

changed /trunk/drjava/src/edu/rice/cs/drjava/ui/AbstractConsoleController.java
changed /trunk/drjava/src/edu/rice/cs/drjava/ui/InteractionsController.java
changed /trunk/drjava/src/edu/rice/cs/drjava/ui/MainFrame.java
changed /trunk/drjava/src/edu/rice/cs/util/swing/AsyncTaskLauncher.java
/trunk/drjava/src/edu/rice/cs/drjava/ui/AbstractConsoleController.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/ui/InteractionsController.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/ui/MainFrame.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/util/swing/AsyncTaskLauncher.java Diff Switch to side-by-side view
Loading...
MongoDB Logo MongoDB