Menu

Commit [r4016]  Maximize  Restore  History

This revision cleans up the code in

FindReplaceMachine/FindReplacePanel in an attempt to make searching
more responsive. The whole word test was coping the text of the
entire document. The revision subjectively feels more responsive but
I don't have any benchmarks to prove it. The tests in MainFrameTest
and DefinitionsPaneTest have been cleaned up; hanging is much less
frequent on my dual core desktop. I am not certain the problem is
completely solved, but I ran about 40 consecutive tests of
MainFrameTest without it hanging, which is a big improvement. The
last goal of this revision was cleaning up the code for quit() in the
MainFrame and global model classes. The dispose method on MainFrame
no longer calls dispose on the model, which is now called only in
tests. The monitoring thread that times out if quitting hangs (on
Windows tablet PC's); we'll see if it has any effect.

The following classes were updated:

M src/edu/rice/cs/drjava/model/GlobalModelTestCase.java
M src/edu/rice/cs/drjava/model/cache/DocumentCache.java
M src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
M src/edu/rice/cs/drjava/model/FindReplaceMachineTest.java
M src/edu/rice/cs/drjava/model/FindReplaceMachine.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/MainFrameTest.java
M src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java

rcartwright 2006-10-13

changed /trunk/drjava/src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
changed /trunk/drjava/src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
changed /trunk/drjava/src/edu/rice/cs/drjava/model/FindReplaceMachine.java
changed /trunk/drjava/src/edu/rice/cs/drjava/model/FindReplaceMachineTest.java
changed /trunk/drjava/src/edu/rice/cs/drjava/model/GlobalModelTestCase.java
changed /trunk/drjava/src/edu/rice/cs/drjava/model/cache/DocumentCache.java
changed /trunk/drjava/src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java
changed /trunk/drjava/src/edu/rice/cs/drjava/ui/FindReplacePanel.java
changed /trunk/drjava/src/edu/rice/cs/drjava/ui/MainFrame.java
changed /trunk/drjava/src/edu/rice/cs/drjava/ui/MainFrameTest.java
/trunk/drjava/src/edu/rice/cs/drjava/model/AbstractGlobalModel.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/model/DefaultGlobalModel.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/model/FindReplaceMachine.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/model/FindReplaceMachineTest.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/model/GlobalModelTestCase.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/model/cache/DocumentCache.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/ui/FindReplacePanel.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/ui/MainFrame.java Diff Switch to side-by-side view
Loading...
/trunk/drjava/src/edu/rice/cs/drjava/ui/MainFrameTest.java Diff Switch to side-by-side view
Loading...
MongoDB Logo MongoDB