Define base appearance for list box select elements #11758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2025
lukewarlow
reviewed
Oct 7, 2025
lukewarlow
reviewed
Oct 7, 2025
lukewarlow
reviewed
Oct 7, 2025
Member
|
I filed #11804 , I can review this again when that is fixed. I would suggest adding tests in this area that check which UA styles are applied, see e.g. https://github.com/web-platform-tests/wpt/blob/master/html/rendering/widgets/the-select-element/select-as-listbox-default-styles.tentative.html |
Contributor
Author
Thanks, I started a fix: #11805
Here is a test I'm working on: https://chromium-review.googlesource.com/c/chromium/src/+/6276680 |
Contributor
Author
|
Now that #11804 has been fixed and I have rebased this PR, and we got a resolution in the sizing issue, and we have a positive standards position from mozilla, this PR is ready for review. |
Member
|
Some of the linked tests are tentative, is there a PR to make them not tentative? |
Contributor
Author
I added a chromium patch to make them non-tentative, which will generate a WPT PR later |
zcorpan
approved these changes
Dec 15, 2025
ajperel
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 22, 2025
Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1561960}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 22, 2025
Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1561960}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 22, 2025
Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1561960}
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Dec 23, 2025
…t-listbox tests, a=testonly Automatic update from web-platform-tests Remove tentative from customizable-select-listbox tests Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1561960} -- wpt-commits: b142a76f0ffffbc95b9053f30dacb2a4737e7f6a wpt-pr: 56900
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 1, 2026
…t-listbox tests, a=testonly Automatic update from web-platform-tests Remove tentative from customizable-select-listbox tests Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonfchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1561960} -- wpt-commits: b142a76f0ffffbc95b9053f30dacb2a4737e7f6a wpt-pr: 56900 UltraBlame original commit: 844b957c47941e80044e2d5c41b415f98cb7c920
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 1, 2026
…t-listbox tests, a=testonly Automatic update from web-platform-tests Remove tentative from customizable-select-listbox tests Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonfchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1561960} -- wpt-commits: b142a76f0ffffbc95b9053f30dacb2a4737e7f6a wpt-pr: 56900 UltraBlame original commit: 844b957c47941e80044e2d5c41b415f98cb7c920
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 1, 2026
…t-listbox tests, a=testonly Automatic update from web-platform-tests Remove tentative from customizable-select-listbox tests Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonfchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1561960} -- wpt-commits: b142a76f0ffffbc95b9053f30dacb2a4737e7f6a wpt-pr: 56900 UltraBlame original commit: 844b957c47941e80044e2d5c41b415f98cb7c920
KurtCattiSchmidt
pushed a commit
to KurtCattiSchmidt/wpt-ahem
that referenced
this pull request
Jan 21, 2026
Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1561960}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines base appearance for select elements which are being rendered as a list box, as opposed to the prior customizable select PR which defined base appearance for drop down select elements.
Fixes #11477
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )
/rendering.html ( diff )