feat!: clear support base independent of mount#645
Open
feat!: clear support base independent of mount#645
clear support base independent of mount#645Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 59.99% 61.45% +1.46%
==========================================
Files 42 42
Lines 3657 3840 +183
Branches 590 650 +60
==========================================
+ Hits 2194 2360 +166
- Misses 1460 1477 +17
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #336
This makes
cleardelete all keys starting withbase- #336 (comment)this PR also includes various other fixes which I discovered while implementing
sry for the big amount of commits - while implementing, I once deleted the whole project folder with the fs drivers and lost all my progress...
unable to test:
azure-cosmos
azure-key-vault
azure-app-configuration
planetscale
vercel-kv - does no longer seem to be a thing
Important
storage expects drivers to correctly implement
clear()and callsclear()on mounts that only partialy contain data which is supposed to be deleted - meaning if clear does not respectbaseunexpected deletions can happen!please test carefully