Optimize JdbcJobExecutionDao#findJobExecutions by reusing the provided JobInstance#5300
Open
l2yujw wants to merge 4 commits intospring-projects:mainfrom
Open
Optimize JdbcJobExecutionDao#findJobExecutions by reusing the provided JobInstance#5300l2yujw wants to merge 4 commits intospring-projects:mainfrom
l2yujw wants to merge 4 commits intospring-projects:mainfrom
Conversation
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
2670910 to
529bc9a
Compare
quaff
reviewed
Feb 25, 2026
...re/src/main/java/org/springframework/batch/core/repository/dao/jdbc/JdbcJobExecutionDao.java
Show resolved
Hide resolved
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JdbcJobExecutionDao#findJobExecutions(JobInstance) already receives a JobInstance, but it previously delegated to getJobExecution(executionId) for each execution id.
That code path re-fetches the JobInstance per execution, resulting in redundant database round-trips (2 * N) in this specific path.
Changes
Reuse the provided JobInstance when mapping JobExecution rows in findJobExecutions(JobInstance).
Factor the shared row-mapping logic into a small private helper (mapJobExecution).
Keep the public getJobExecution(executionId) behavior unchanged.
Notes
Updated the TODO comment to reflect remaining opportunities to reduce round-trips further (e.g., retrieving executions and parameters in fewer queries).