Introduce ErrorProne, fix compiler warnings by scordio · Pull Request #4807 · spring-projects/spring-batch

scordio · 2025-04-05T07:49:15Z

This PR introduces ErrorProne, sets the maven-compiler-plugin to fail in case of compiler warnings, and fixes all the warnings.

This is a preparation for:

Migrate to JSpecify annotations for nullability constraints #4673

fmbenhassine · 2025-04-08T12:17:06Z

This is fantastic! Thank you for doing that, @scordio !

I have a plan to re-work/optimise the project's build/release process for the next major release (see #4319 as well), and this goes in that same direction.

When this is not a draft PR anymore, please let me know and it should be welcome to merge.

scordio

Hi @fmbenhassine, I am finally ready with the changes!

I think there are a few flaky tests like:

SimpleStepFactoryBeanTests.testSimpleConcurrentJob
JdbcPagingItemReaderCommonTests

I couldn't figure out the root cause, but the failing ones are green with single executions in the IDE or when retrying a complete Maven build... if you have any hints, please let me know!

scordio · 2025-05-06T22:19:03Z

...tch-core/src/main/java/org/springframework/batch/core/repository/dao/JdbcJobInstanceDao.java

+	@SuppressWarnings("unused")
 	private static final String STAR_WILDCARD = "*";

+	@SuppressWarnings("unused")
 	private static final String SQL_WILDCARD = "%";


I suppressed the warnings here, but it might make sense to delete them instead.

scordio · 2025-05-06T22:19:35Z

...ructure/src/main/java/org/springframework/batch/item/file/transform/ConversionException.java

+@SuppressWarnings("unused") // FIXME no usage - should it be deprecated for removal?
 public class ConversionException extends RuntimeException {


As the comment mentions, ConversionException is currently unused in the codebase.

Should this be deprecated for removal?

Yes, I will take care of that separately. Thank you for adding that "FIXME" for reference 👍

scordio · 2025-05-28T17:54:51Z

pom.xml

+							-Xep:AlmostJavadoc:OFF
+							-Xep:BadInstanceof:OFF <!-- FIXME gh-4839 -->
+							-Xep:ByteBufferBackingArray:OFF
+							-Xep:ClassCanBeStatic:OFF
+							-Xep:CollectionUndefinedEquality:OFF
+							-Xep:DefaultCharset:OFF
+							-Xep:DirectInvocationOnMock:OFF
+							-Xep:DoNotCallSuggester:OFF
+							-Xep:EmptyCatch:OFF
+							-Xep:EqualsGetClass:OFF
+							-Xep:Finally:OFF
+							-Xep:FutureReturnValueIgnored:OFF
+							-Xep:HidingField:OFF
+							-Xep:ImmutableEnumChecker:OFF
+							-Xep:InlineMeSuggester:OFF
+							-Xep:InputStreamSlowMultibyteRead:OFF
+							-Xep:JavaTimeDefaultTimeZone:OFF
+							-Xep:JavaUtilDate:OFF
+							-Xep:JdkObsolete:OFF
+							-Xep:MissingSummary:OFF
+							-Xep:MixedMutabilityReturnType:OFF
+							-Xep:MutablePublicArray:OFF
+							-Xep:NonAtomicVolatileUpdate:OFF
+							-Xep:RedundantControlFlow:OFF
+							-Xep:ReferenceEquality:OFF
+							-Xep:StaticAssignmentInConstructor:OFF
+							-Xep:StaticAssignmentOfThrowable:OFF
+							-Xep:StaticMockMember:OFF
+							-Xep:StreamResourceLeak:OFF
+							-Xep:StringCaseLocaleUsage:OFF
+							-Xep:StringSplitter:OFF
+							-Xep:SynchronizeOnNonFinalField:OFF
+							-Xep:ThreadLocalUsage:OFF
+							-Xep:ThreadPriorityCheck:OFF
+							-Xep:TypeParameterUnusedInFormals:OFF
+							-Xep:UndefinedEquals:OFF
+							-Xep:UnnecessaryStringBuilder:OFF
+							-Xep:UnusedMethod:OFF
+							-Xep:UnusedVariable:OFF
+							-Xep:WaitNotInLoop:OFF


I excluded all the ErrorProne warnings that didn't have a straightforward solution.

I would suggest addressing them in separate PRs.

Yes that's fine, we can address those in separate PRs.

pom.xml

scordio · 2025-06-02T17:04:41Z

... and now the build is green! 😅

Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>

fmbenhassine · 2025-06-03T23:10:26Z

This is a huge amount of work! Thank you very much for doing that, @scordio 👍

I know you had to rebase this several times due to the latest changes in the code base, really appreciated

Rebased, squashed and merged as 74975c5.

scordio · 2025-06-03T23:13:55Z

Thanks! I'll continue with #4673 in the upcoming days 🙂

This comment was marked as outdated.

Sign in to view

scordio marked this pull request as draft April 6, 2025 08:05

scordio force-pushed the cosmetic branch from daf0f98 to 18dd907 Compare April 7, 2025 07:17

scordio changed the title ~~Favor factory methods instead of double braces initialization~~ Introduce ErrorProne, fix compiler warnings Apr 7, 2025

scordio force-pushed the cosmetic branch 2 times, most recently from 8eb3acc to 8a6ddaf Compare April 7, 2025 22:27

scordio force-pushed the cosmetic branch 5 times, most recently from f0efc64 to 459933c Compare April 13, 2025 15:02

scordio force-pushed the cosmetic branch 17 times, most recently from 6349088 to 48ae732 Compare May 7, 2025 06:38

scordio mentioned this pull request May 9, 2025

Replace spotbugs with errorprone jqno/equalsverifier#1073

Merged

scordio force-pushed the cosmetic branch from 48ae732 to 13488b1 Compare May 9, 2025 22:52

scordio closed this May 9, 2025

scordio deleted the cosmetic branch May 9, 2025 23:28

scordio restored the cosmetic branch May 9, 2025 23:29

scordio reopened this May 9, 2025

scordio force-pushed the cosmetic branch 2 times, most recently from 4f4dbfa to ec33b20 Compare May 28, 2025 14:33

scordio commented May 28, 2025

View reviewed changes

scordio marked this pull request as ready for review May 28, 2025 18:13

scordio commented May 28, 2025

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

scordio force-pushed the cosmetic branch 2 times, most recently from e96e01d to aaf4582 Compare June 2, 2025 16:53

scordio force-pushed the cosmetic branch from aaf4582 to e867fe6 Compare June 3, 2025 22:27

scordio added 2 commits June 4, 2025 00:44

Introduce ErrorProne, fix compiler warnings

5d7b731

Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>

Remove BadInstanceof exclusion

7dffbd7

Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>

scordio force-pushed the cosmetic branch from e867fe6 to 7dffbd7 Compare June 3, 2025 22:47

fmbenhassine closed this Jun 3, 2025

fmbenhassine added pr-for: enhancement in: build labels Jun 3, 2025

fmbenhassine added this to the 6.0.0-M1 milestone Jun 3, 2025

scordio deleted the cosmetic branch June 3, 2025 23:14

cppwfs mentioned this pull request Jun 4, 2025

Remove unused imports #4862

Closed

scordio referenced this pull request Jun 9, 2025

Remove build failure on warnings

72694e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce ErrorProne, fix compiler warnings#4807

Introduce ErrorProne, fix compiler warnings#4807
scordio wants to merge 2 commits intospring-projects:mainfrom
scordio:cosmetic

scordio commented Apr 5, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

fmbenhassine commented Apr 8, 2025

Uh oh!

scordio left a comment

Uh oh!

scordio May 6, 2025 •

edited

Loading

Uh oh!

scordio May 6, 2025 •

edited

Loading

Uh oh!

fmbenhassine Jun 3, 2025

Uh oh!

scordio May 28, 2025 •

edited

Loading

Uh oh!

fmbenhassine Jun 3, 2025

Uh oh!

Uh oh!

scordio commented Jun 2, 2025

Uh oh!

fmbenhassine commented Jun 3, 2025

Uh oh!

scordio commented Jun 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@SuppressWarnings("unused") // FIXME no usage - should it be deprecated for removal?
		public class ConversionException extends RuntimeException {

Conversation

scordio commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

fmbenhassine commented Apr 8, 2025

Uh oh!

scordio left a comment

Choose a reason for hiding this comment

Uh oh!

scordio May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scordio May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmbenhassine Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

scordio May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmbenhassine Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

scordio commented Jun 2, 2025

Uh oh!

fmbenhassine commented Jun 3, 2025

Uh oh!

scordio commented Jun 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

scordio commented Apr 5, 2025 •

edited

Loading

scordio May 6, 2025 •

edited

Loading

scordio May 6, 2025 •

edited

Loading

scordio May 28, 2025 •

edited

Loading