Fix failed assertion with Mbed TLS 3#3017
Open
ayuusweetfish wants to merge 1 commit intoshadowsocks:masterfrom
Open
Fix failed assertion with Mbed TLS 3#3017ayuusweetfish wants to merge 1 commit intoshadowsocks:masterfrom
ayuusweetfish wants to merge 1 commit intoshadowsocks:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiled against Mbed TLS 3 (on my environment, Fedora's
mbedtls-3.6.5-1.fc42.aarch64), the client program reports a failed assertion:This appears to have been introduced by #2999. Indeed, the resource referenced there (fw876/helloworld#1504) provides a patch that contains an identical change; it might be an overlook when porting. I have tested the change with MSan and UBSan.
Ref.
mbedtls_cipher_auth_encrypt_ext()documentation: "the tag will be appended to the ciphertext", so the output length already includes the tag and no longer needs another+= tlen.I hope this helps.