Skip to content

Fixed inconsistencies in expected types for Date & Time expecting properties#2273

Merged
danbri merged 2 commits intomasterfrom
issue-2271
Jun 18, 2019
Merged

Fixed inconsistencies in expected types for Date & Time expecting properties#2273
danbri merged 2 commits intomasterfrom
issue-2271

Conversation

@RichardWallis
Copy link
Contributor

@RichardWallis RichardWallis commented Jun 13, 2019

Added Date to rangeInclude for orderDate, validFrom, validThrough, paymentDueDate, expectedArrivalFrom, expectedArrivalUntil, dateRead, availabilityStarts, availabilityEnds, dateDeleted, dateIssued.

Added Time to the rangeIncludes for checkoutTime, checkinTime, checkinTime, arrivalTime,
departureTime, availabilityStarts, availabilityEnds, doorTime, endTime, startTime.
Fix for issue #(2271)

…aymentDueDate,

expectedArrivalFrom, expectedArrivalUntil, dateRead, availabilityStarts,
availabilityEnds, dateDeleted, dateIssued
and Time to the rangeIncludes for checkoutTime, checkinTime, checkinTime, arrivalTime,
departureTime, doorTime, endTime, startTime.
Fix for issue #(2271)
@gkellogg
Copy link
Contributor

From the Travis run, it looks like there's more low-hanging fruit:

  • availabilityStarts – include Time in range
  • availabilityEnds – include Time in range

@danbri danbri merged commit 23bde9b into master Jun 18, 2019
@RichardWallis RichardWallis deleted the issue-2271 branch November 13, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants