Skip to content

fix(core): fix critical storage corruption on deduplicate write resulting to same data#6359

Merged
bluestreak01 merged 3 commits intomasterfrom
fix-partition-done-race
Nov 8, 2025
Merged

fix(core): fix critical storage corruption on deduplicate write resulting to same data#6359
bluestreak01 merged 3 commits intomasterfrom
fix-partition-done-race

Conversation

@ideoma
Copy link
Collaborator

@ideoma ideoma commented Nov 7, 2025

Critical storage issue introduced in #5764 and released in 9.0.0.

Very likely to happen on a materialized view refresh that results in the same data as already in the view.
The bug may result in double memory close and the deletion of the wrong directories on the box.

@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-partition-done-race

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@glasstiger
Copy link
Contributor

[PR Coverage check]

😍 pass : 7 / 7 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/O3PartitionJob.java 7 7 100.00%

@bluestreak01 bluestreak01 merged commit 01b6035 into master Nov 8, 2025
36 checks passed
@bluestreak01 bluestreak01 deleted the fix-partition-done-race branch November 8, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants