hey @kafka1991 i am not able to use the test to reproduce the issue, are there special considerations? E.g. platform etc?

hey @kafka1991 i am not able to use the test to reproduce the issue, are there special considerations? E.g. platform etc?

Revert changes in SqlCompilerImpl.java and try to run test testInsertAsSelectWithConcurrentSchemaChange, It's not a consistently reproducible bug, but it appears once every few runs (about 2-3 times).

The issue with it is also quite simple. In the generateSelectWithRetries function that was being used in InserAsSelect, there's a problem with the exception handling(and retries):

            } catch (TableReferenceOutOfDateException e) {
                if (--remainingRetries < 0) {
                    throw SqlException.position(0).put("too many ").put(e.getFlyweightMessage());
                }
                LOG.info().$("retrying plan [q=`").$(queryModel).$("`, fd=").$(executionContext.getRequestFd()).I$();
                clearExceptSqlText();
                lexer.restart();
                queryModel = (QueryModel) compileExecutionModel(executionContext);
            }

After lexer.restart(), the compileExecutionModel(executionContext) that gets recompiled is an InsertModel instead of QueryModel for an InsertSelect query .

[PR Coverage check]

😍 pass : 4 / 7 (57.14%)

file detail