Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My collections changes didn't work after being merged in with the latest master. I believe I found the root cause and fixed everything.
Properties that were collection types were always returning null because generic instantiations don't have runtime types and were incorrectly flagged as by-ref (shared/sdk/RETypeDefinition.cpp).
Calling instance methods on ValueTypes (e.g. struct enumerator MoveNext) was broken because the fake boxed object prepended a 0x10 header that the native invoke wrapper doesn't expect, it passes the pointer directly as
this, so the method was reading the header bytes as struct fields (csharp-api/REFrameworkNET/Method.cpp). The fix preserves the GC safety of copying to a native buffer but removes the incorrect header.I believe the changes in Method.cpp preserve the original fixes and shouldn't reintroduce any issues. However, the change in RETypeDefinition.cpp I'm less certain of and worried it could reintroduce a problem in MH Wilds, but I don't have that game to test it.