This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Conversation
Marc-Andre-Rivet
approved these changes
Sep 11, 2019
Contributor
Marc-Andre-Rivet
left a comment
There was a problem hiding this comment.
💃 for when plotly/dash#903 is ready
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to plotly/dash#903 - there's no code here other than the transforms to connect up just the
nameattribute fromcolumns. The main decisions here have to do with the defaults - my thinking is that the easiest thing for users is if all eligible props are included by default (exceptdatabecause I it seems like an unusual use case to persist that) so that in the most common use case, to enable persistence you just need to setpersistence=True. Alsopersistence_type='local'seems clear.Will test this on the dash side - since even the little transform code here primarily needs to be tested in as far as it gets invoked properly there.