chore(dev-deps): align @types/node with Node.js 18.19+ support#1388
Open
ognis1205 wants to merge 3 commits intoorhun:mainfrom
Open
chore(dev-deps): align @types/node with Node.js 18.19+ support#1388ognis1205 wants to merge 3 commits intoorhun:mainfrom
ognis1205 wants to merge 3 commits intoorhun:mainfrom
Conversation
Collaborator
Author
|
cc: @favna |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
=======================================
Coverage 47.57% 47.57%
=======================================
Files 24 24
Lines 2119 2119
=======================================
Hits 1008 1008
Misses 1111 1111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Would be nice to ping @favna on Discord. He told me his GitHub notifications are off |
d442e64 to
082f267
Compare
082f267 to
1354a55
Compare
Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
1354a55 to
34d5f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@types/nodeversion specification to^18.19.engines.nodeconstraint from>=18.19 || >=20.6 || >=21to^18.19 || >=20.6.Motivation and Context
engines.nodeconstraint (>=18.19 || >=20.6 || >=21) was redundant, since>=18.19already covers20and21.@types/nodeversion was previously set to24.x, which is intended for Node.js24.engines.nodeconstraint (>=18.19 || >=20.6 || >=21) indicates that the package is intended to run on Node.js18.19+and20.6+.See also:
How Has This Been Tested?
yarn installyarn typecheckyarn lintyarn buildyarn devScreenshots / Logs (if applicable)
N/A
Types of Changes
Checklist:
cargo +nightly fmt --allcargo clippy --tests --verbose -- -D warningscargo test