Skip to content

doc: Added entry for run command option watch-ignored #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caitmuenster merged 15 commits into from
Jan 12, 2021
Merged

doc: Added entry for run command option watch-ignored #873

caitmuenster merged 15 commits into from
Jan 12, 2021

Conversation

@ankushduacodes
Copy link
Contributor

@ankushduacodes ankushduacodes commented Dec 27, 2020

fixes #871

@caitmuenster caitmuenster requested a review from rpl January 4, 2021 20:57
@caitmuenster
Copy link
Contributor

caitmuenster commented Jan 4, 2021

Thanks @ankushduacodes! This looks good to me.

@rpl, could you review as well?

rpl
rpl requested changes Jan 11, 2021
View reviewed changes
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushduacodes Thanks for preparing the PR to update the web-ext CLI options documentation!

I just got back from and took a look to the changes in this PR, follows some review comments related to a couple of nits.

@ankushduacodes ankushduacodes requested a review from rpl January 11, 2021 12:51
rpl
rpl requested changes Jan 11, 2021
View reviewed changes
@ankushduacodes ankushduacodes requested a review from rpl January 11, 2021 16:47
rpl
rpl approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ankushduacodes!!!

@caitmuenster I approved this version from a technical perspective, there have been some changes to the note alert part from the previous version you looked to, you may take a look in case part of the content that I suggested to put there could be written in a slightly better way (and if there are typos in there then all the blame is mine ;-))

@caitmuenster
Copy link
Contributor

caitmuenster commented Jan 12, 2021

Thank you so much, @ankushduacodes! 🏅

@caitmuenster caitmuenster merged commit 6507ca5 into mozilla:master Jan 12, 2021
@ankushduacodes
Copy link
Contributor Author

ankushduacodes commented Jan 12, 2021

Many more to go 🚀

@ankushduacodes ankushduacodes deleted the add_docs_for_--watch-ignored_opt branch January 12, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rpl rpl rpl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add docs for new --watch-ignored command line option

3 participants

@ankushduacodes @caitmuenster @rpl