Updated the API docs for homepage shelves endpoint #17054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API response was incorrect for the /shelves/ endpoint. It mentions headline instead of title and cta.text instead of footer.text. The documentation needs to be updated to reflect the actual API response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#8315
The API response was incorrect for the
/shelves/endpoint. It mentionsheadlineinstead oftitleandcta.textinstead offooter.text. Thedocumentation needs to be updated to reflect the actual API response.
Thanks for opening a Pull Request (PR), here's a few guidelines as to what we need in your PR before we review it.
Please delete anything that isn't relevant to your patch.
PRs open for the same issue.
Fixes #ISSUENUMat the top of your PR.