Skip to content

Fixes #16744 Extension Workshop URLS must end with a trailing slash to not lose query params #16923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eviljeff merged 1 commit into from
Apr 13, 2021
Merged

Fixes #16744 Extension Workshop URLS must end with a trailing slash to not lose query params #16923

eviljeff merged 1 commit into from
Apr 13, 2021

Conversation

@siddhi523
Copy link
Contributor

@siddhi523 siddhi523 commented Apr 12, 2021

Fixes mozilla/addons#8252

Added / before ? in three links inside src/olympia/devhub/templates/devhub/nav.html

eviljeff
eviljeff approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ thanks

@eviljeff eviljeff merged commit e0155d1 into mozilla:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eviljeff eviljeff eviljeff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extension Workshop URLS must end with a trailing slash to not lose query params

2 participants

@siddhi523 @eviljeff