Skip to content

Conversation

@pranav1601
Copy link
Contributor

@pranav1601 pranav1601 commented Apr 15, 2021

Fixes mozilla/addons#14092

added bug reporting information to about page

after

before

@codecov-io
Copy link

codecov-io commented Apr 15, 2021

Codecov Report

Merging #10392 (3efffd9) into master (bd709d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   mozilla/addons-frontend#10392   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         254      254           
  Lines        7423     7423           
  Branches     1363     1363           
=======================================
  Hits         7304     7304           
  Misses        111      111           
  Partials        8        8           
Impacted Files Coverage Δ
src/amo/pages/StaticPages/About/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd709d5...3efffd9. Read the comment docs.

@bobsilverberg bobsilverberg requested review from a team and bobsilverberg and removed request for a team April 15, 2021 11:49
Copy link
Contributor

@bobsilverberg bobsilverberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @pranav1601. The changes to .husky/pre-commit should not be included in this patch. I'm not sure what caused those changes.

@pranav1601
Copy link
Contributor Author

hey @bobsilverberg ,
I was getting an error when i was trying to commit saying .husky/pre-commit not found. I have fixed it now and I have committed it as well.
Thanks!

Copy link
Contributor

@bobsilverberg bobsilverberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pranav1601. The .husky/pre-commit still needs to be dealt with.

. "$(dirname "$0")/_/husky.sh"

flow && lint-staged
flow && lint-staged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still detecting a difference because this file is missing a new line at the end. This patch shouldn't contain any changes to .husky/pre-commit

@pranav1601
Copy link
Contributor Author

Hey @bobsilverberg ,
didnt see that new line! Corrected it now though. Please review it.
Thanks!

Copy link
Contributor

@bobsilverberg bobsilverberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work @pranav1601! Thanks for the patch.

@bobsilverberg bobsilverberg merged commit 40e4dae into mozilla:master Apr 15, 2021
@pranav1601 pranav1601 deleted the 10351-add-bug-reporting-information-to-about-page branch April 15, 2021 17:54
@pranav1601
Copy link
Contributor Author

Thanks @bobsilverberg !

@caitmuenster
Copy link

Yay, thank you so much, @pranav1601! 🎉Your contribution has been added to our recognition wiki.

Hope to see you around the project in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bug reporting information to /about page

4 participants