-
Notifications
You must be signed in to change notification settings - Fork 402
10351 add bug reporting information to about page #10392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10351 add bug reporting information to about page #10392
Conversation
Codecov Report
@@ Coverage Diff @@
## master mozilla/addons-frontend#10392 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 254 254
Lines 7423 7423
Branches 1363 1363
=======================================
Hits 7304 7304
Misses 111 111
Partials 8 8
Continue to review full report at Codecov.
|
bobsilverberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks @pranav1601. The changes to .husky/pre-commit should not be included in this patch. I'm not sure what caused those changes.
|
hey @bobsilverberg , |
bobsilverberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pranav1601. The .husky/pre-commit still needs to be dealt with.
.husky/pre-commit
Outdated
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| flow && lint-staged | ||
| flow && lint-staged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still detecting a difference because this file is missing a new line at the end. This patch shouldn't contain any changes to .husky/pre-commit
|
Hey @bobsilverberg , |
bobsilverberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work @pranav1601! Thanks for the patch.
|
Thanks @bobsilverberg ! |
ℹ No staged files match any configured task. to match with main file
|
Yay, thank you so much, @pranav1601! 🎉Your contribution has been added to our recognition wiki. Hope to see you around the project in the future! |
Fixes mozilla/addons#14092
added bug reporting information to about page