Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7315 +/- ##
=========================================
Coverage ? 99.65%
=========================================
Files ? 262
Lines ? 25721
Branches ? 6622
=========================================
Hits ? 25631
Misses ? 84
Partials ? 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…bility Adds a `readonly()` method to the `defineEntity` property builder that marks properties as `readonly` on the inferred entity type. This is purely a TypeScript feature — it prevents assignment outside the constructor but has no runtime effect on ORM behavior. The implementation uses a `ReadonlyBuilderKeys` type parameter on `InferEntityFromProperties` with a `[RK] extends [never]` fast-path that avoids overhead when no properties use `readonly()`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4724c6b to
c816faa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readonly()method to thedefineEntityproperty builder that marks properties asreadonlyon the inferred entity typeReadonlyBuilderKeystype parameter onInferEntityFromPropertieswith a[RK] extends [never]fast-pathType performance
readonly()used)ReadonlyBuilderKeysevaluation)Test plan
readonlymodifier on inferred entity typeyarn bench:types— all benchmarks at 0.00% delta after baseline updatesyarn tsc-check-tests— no new errorsdefineEntity.test.tspasses with new readonly test case🤖 Generated with Claude Code