Point comment zone widget 'beak' arrow at single-line range (#173690)#174291
Point comment zone widget 'beak' arrow at single-line range (#173690)#174291alexr00 merged 3 commits intomicrosoft:mainfrom
Conversation
|
/assign @alexr00 |
|
@alexr00 I know you are busy on a quickdiff PR at the moment, but I'd be grateful if you could review this one and ideally approve & merge it in time for tomorrow's Insiders. Tomorrow I'll be demoing an extension of mine called gj :: codeSpex on a public webinar, and it'd be extra-cool for the beaks to point correctly. Out of the box that extension adds comments to editors that are using languages handled by the InterSystems Language Server, but you can make it light up in ones where languageId is typescript if you add these lines to your settings.json "codeSpex.languages": {
"typescript":{
"tokens": {
"class": {
"enabled": true
},
"constructor": {
"enabled": true
},
"function": {
"enabled": true
},
"method": {
"enabled": true
}
}
},
},Example from the Treeview Sample code:
|
alexr00
left a comment
There was a problem hiding this comment.
Looks good! I just have one question.
|
@gjsjohnmurray this didn't make it into the latest released insiders, but here's an insiders build that has it in case that's helpful for you: https://az764295.vo.msecnd.net/insider/fb256581df0c63f5b9274fb99cf59bb496523f05/VSCode-win32-x64-1.76.0-insider.zip |
|
@alexr00 brilliant! Thanks very much. |
…t#173690) (microsoft#174291) * Point comment zone widget 'beak' arrow at single-line range (microsoft#173690) * Remove unused variable
|
@alexr00 thanks again for that link yesterday. There doesn't seem to have been an Insiders published today yet. Do you know if there's a problem? |
|
@gjsjohnmurray We've been plagued with build issues outside of our control and haven't been able to get a build yet :( |
This PR fixes #173690.
When a comment thread references a range not spanning multiple lines, position the 'beak' arrow to point at midpoint of the range (rounding rightward).