Replaced true and false with on and off in debug.inlineValues#146543
Merged
roblourens merged 2 commits intomicrosoft:mainfrom Apr 4, 2022
Merged
Replaced true and false with on and off in debug.inlineValues#146543roblourens merged 2 commits intomicrosoft:mainfrom
roblourens merged 2 commits intomicrosoft:mainfrom
Conversation
roblourens
reviewed
Apr 4, 2022
| @@ -419,7 +419,7 @@ configurationRegistry.registerConfiguration({ | |||
| }, | |||
| 'debug.inlineValues': { | |||
| type: ['boolean', 'string'], | |||
Member
There was a problem hiding this comment.
This also can remove "boolean", I'll fix that in main
Contributor
Author
There was a problem hiding this comment.
Ah, you're right, I didn't see it. Thank you!
Member
|
Thanks for the PR! |
roblourens
added a commit
that referenced
this pull request
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #143543
For retro compatibility
booleanis still allowed inIDebugConfiguration.inlineValuesand the setting is still matched againsttrue.