Using Offset instead of address from disassembly#129760
Closed
yuehuang010 wants to merge 2 commits intomicrosoft:mainfrom
Closed
Using Offset instead of address from disassembly#129760yuehuang010 wants to merge 2 commits intomicrosoft:mainfrom
yuehuang010 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Fix an issue when scrolling too fast. RemoveAllBreakPoint will also remove InstructionBP.
47672cf to
1266242
Compare
Collaborator
|
This looks good, however changing offsets are imho always a bit risky, so I would prefer to merge this in start of next week. |
Contributor
Author
|
@isidorn Sounds reasonable. |
Contributor
|
I think you need to update currentAddress on stack frame changes? I would suggest not to cache and update current address in the reset function, and instead, change the |
Contributor
Author
|
Abandon for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to use offset and a constant memoryReference from stackFrame. #129655
Fix an issue when scrolling too fast by using a "lock".
RemoveAllBreakPoint will also remove InstructionBP. #129572
This PR fixes #129572 #129655
@isidorn @weinand