Skip to content

Add Copy Command Label to Keyboard Shortcuts.#125563

Merged
sandy081 merged 1 commit intomicrosoft:mainfrom
timfenney:add-copy-command-label-fixes-issue-125092
Jul 6, 2021
Merged

Add Copy Command Label to Keyboard Shortcuts.#125563
sandy081 merged 1 commit intomicrosoft:mainfrom
timfenney:add-copy-command-label-fixes-issue-125092

Conversation

@timfenney
Copy link

@timfenney timfenney commented Jun 4, 2021

This PR fixes #125092.

@ghost
Copy link

ghost commented Jun 4, 2021

CLA assistant check
All CLA requirements met.

@timfenney timfenney force-pushed the add-copy-command-label-fixes-issue-125092 branch from 1d049c3 to 2e5bf7e Compare June 4, 2021 22:55
@timfenney
Copy link
Author

@sandy081 did you get time to take a l:eyes:k at this yet?

@sandy081
Copy link
Member

sandy081 commented Jun 8, 2021

Instead of context menu can you please make the text selectable?

@timfenney
Copy link
Author

timfenney commented Jun 9, 2021

Instead of context menu can you please make the text selectable?

It is a good idea! What way should it be selectable? The UI already allows:

  • single click to select row
  • double click to add keyboard shortcut

...for this reason, I am not sure what is a good UX here. What do you think @sandy081 🤔 ?

Also, we have 2 ways of copying aspects of the command via context menu already. Is it orthogonal to have a 3rd way of copying something from the command somewhere else?

Alternatively, what do you think of adding a copy button? I am not sure it belongs in the action buttons at the beginning of the row, but could go inside the td with the label.

alt text
alt text

@sandy081
Copy link
Member

sandy081 commented Jun 9, 2021

Please ignore my previous comment. After thinking more I felt initial approach of providing the copy command in the context menu makes sense. Please let me know if the changes with context menu option are ready for review.

@timfenney
Copy link
Author

@sandy081 it is ready for review 👍

@sandy081 sandy081 added this to the June 2021 milestone Jun 9, 2021
@sandy081 sandy081 modified the milestones: June 2021, July 2021 Jul 1, 2021
Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandy081 sandy081 merged commit 9f1f2d8 into microsoft:main Jul 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] Copy Command Title

2 participants