Add sysroot to compile Linux prebuilds against glibc 2.28 #853
+287
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Approach LGTM, can you also add a step in the CI to verify the binaries contain the required version of glibc. Refs https://github.com/microsoft/vscode/blob/d2894816734dc9141885b802805801b67d70e6e9/build/azure-pipelines/linux/steps/product-build-linux-compile.yml#L238-L250 as an example. |
Contributor
Author
Thanks @deepak1556! Great suggestion! Added in 965cf18 which did catch an issue. Fixed in 26ba629 |
deepak1556
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #851