Skip to content
This repository was archived by the owner on Jul 19, 2024. It is now read-only.

Support for custom delegate-based events and fix for indentation in generated stubs#17

Merged
nehmebilal merged 2 commits intomicrosoft:masterfrom
mclift:master
Mar 11, 2017
Merged

Support for custom delegate-based events and fix for indentation in generated stubs#17
nehmebilal merged 2 commits intomicrosoft:masterfrom
mclift:master

Conversation

@mclift
Copy link
Copy Markdown

@mclift mclift commented Mar 11, 2017

I never got to the bottom of why the parsed if/else blocks seemed to get ignored by the Formatter, but it does a much better job of indentation when they're added via SyntaxFactory.IfStatement(...).

@msftclas
Copy link
Copy Markdown

@mclift,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mclift mclift changed the title Fixed indentation in generated stubs. Support for custom delegate-based events and fix for indentation in generated stubs Mar 11, 2017
@mclift
Copy link
Copy Markdown
Author

mclift commented Mar 11, 2017

Also took a look at issue #7. Swapping out sender[, args] for the event delegate's invocation method parameters seems to generate the correct behavior in the scenario described in the issue, although there's room for better test coverage here. Let me know your thoughts!

@nehmebilal
Copy link
Copy Markdown
Collaborator

Looks fantastic! Thanks @mclift!

@nehmebilal nehmebilal merged commit fa5109e into microsoft:master Mar 11, 2017
@nehmebilal
Copy link
Copy Markdown
Collaborator

Btw you'd probably want to setup your user.email in Git so you can get your info showing correctly on your commits :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants