Add pointLatLon convenience method#165
Merged
dsmiley merged 2 commits intolocationtech:masterfrom Aug 28, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
============================================
+ Coverage 75.14% 75.15% +0.01%
+ Complexity 1096 1093 -3
============================================
Files 57 57
Lines 3794 3800 +6
Branches 772 772
============================================
+ Hits 2851 2856 +5
- Misses 664 667 +3
+ Partials 279 277 -2
Continue to review full report at Codecov.
|
89a09e0 to
bc7c59b
Compare
Contributor
Author
|
I am not to sure about fb5aa6b, but I think it makes sense to add getLat and getLon to Point as well. |
Contributor
|
Looks good to me! Thanks. Please do squash to two commits -- one for jacoco and the other for the rest. |
Signed-off-by: MoeweX <Jonathan@Hasenburg.de>
Signed-off-by: MoeweX <Jonathan@Hasenburg.de>
Contributor
Author
|
Thx @dsmiley , I squashed the commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds a pointLatLon convenience method as proposed in #164 .
I also noticed that the project cannot be build with Maven and Java 9 due to the error described here. Thus, I bumped the JaCoCo plugin version to 0.8.2 which is the newest one available.
EDIT: I can squash the commits if necessary.