refactor: fixing disabled behavior for ht-link#915
Merged
anandtiwary merged 6 commits intomainfrom Jun 9, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #915 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 803 803
Lines 16509 16509
Branches 2073 2073
=======================================
Hits 14090 14090
Misses 2387 2387
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| *ngIf="this.navigationPath" | ||
| class="ht-link" | ||
| [ngClass]="{ disabled: this.disabled }" | ||
| [ngClass]="{ disabled: (this.disabled || this.navigationPath)}" |
Contributor
There was a problem hiding this comment.
Wouldn't we want to negate this? this would eval true if not disabled and a path is provided.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Jun 9, 2021
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
refactor: fixing disabled behavior for ht-link
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.