Skip to content

fix: updating label since chart shows selectable interval#830

Merged
anandtiwary merged 1 commit intomainfrom
update-label
May 7, 2021
Merged

fix: updating label since chart shows selectable interval#830
anandtiwary merged 1 commit intomainfrom
update-label

Conversation

@anandtiwary
Copy link
Copy Markdown
Contributor

@anandtiwary anandtiwary commented May 7, 2021 •
edited
Loading

Description

Please include a summary of the change, motivation and context.
fix: updating label since chart shows selectable interval

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner May 7, 2021 19:28
@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2021 •
edited
Loading

Codecov Report

Merging #830 (f9302d4) into main (9ccc33d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         793      793           
  Lines       16231    16231           
  Branches     1930     1930           
=======================================
  Hits        13865    13865           
  Misses       2334     2334           
  Partials       32       32
Impacted Files Coverage Δ
...s/apis/api-detail/metrics/api-metrics.dashboard.ts 100.00% <ø> (ø)
...ackend-detail/metrics/backend-metrics.dashboard.ts 100.00% <ø> (ø)
...ervice-detail/metrics/service-metrics.dashboard.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ccc33d...f9302d4. Read the comment docs.

@github-actions

This comment has been minimized.

Sign in to view
@anandtiwary anandtiwary merged commit 812e70f into main May 7, 2021
@anandtiwary anandtiwary deleted the update-label branch May 7, 2021 20:21
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 7, 2021

Unit Test Results

    4 files  ±0  250 suites  ±0   14m 16s ⏱️ - 1m 19s
899 tests ±0  899 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
905 runs  ±0  905 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 812e70f. ± Comparison against base commit 9ccc33d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jake-bassett jake-bassett jake-bassett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anandtiwary @jake-bassett