Skip to content

fix: enable selectable time intervals for metrics across all screens#807

Merged
JBAhire merged 1 commit intomainfrom
enable-selectable-metrics
May 3, 2021
Merged

fix: enable selectable time intervals for metrics across all screens#807
JBAhire merged 1 commit intomainfrom
enable-selectable-metrics

Conversation

@JBAhire
Copy link
Copy Markdown
Member

@JBAhire JBAhire commented May 3, 2021

Description

Resolves #749 by making changes as per the discussion here: #749 (comment) .

Enabling selectable-interval will show up in UI like this screenshot from earlier version:

image

Testing

NA

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link
Copy Markdown

codecov bot commented May 3, 2021 •
edited
Loading

Codecov Report

Merging #807 (a009ee2) into main (969ecaa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         792      792           
  Lines       16192    16192           
  Branches     2069     2069           
=======================================
  Hits        13832    13832           
  Misses       2329     2329           
  Partials       31       31
Impacted Files Coverage Δ
...apis/api-detail/overview/api-overview.dashboard.ts 100.00% <ø> (ø)
...kend-detail/overview/backend-overview.component.ts 40.00% <ø> (ø)
...vice-detail/overview/service-overview.dashboard.ts 100.00% <ø> (ø)
src/app/home/home.dashboard.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969ecaa...a009ee2. Read the comment docs.

@github-actions

This comment has been minimized.

Sign in to view
@JBAhire JBAhire marked this pull request as ready for review May 3, 2021 04:14
@JBAhire JBAhire requested a review from a team as a code owner May 3, 2021 04:14
@kotharironak kotharironak requested a review from anandtiwary May 3, 2021 04:18
anandtiwary
anandtiwary approved these changes May 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@anandtiwary anandtiwary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we change it to false recently?

@JBAhire
Copy link
Copy Markdown
Member Author

JBAhire commented May 3, 2021

Did we change it to false recently?

Actually, it has been false since long time. That change happened post launch. I think @arjunlalb , @aaron-steinfeld or @skjindal93 might have some additional context here.

@JBAhire JBAhire merged commit a8a7f6f into main May 3, 2021
@JBAhire JBAhire deleted the enable-selectable-metrics branch May 3, 2021 04:56
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 3, 2021

Unit Test Results

    4 files  ±0  250 suites  ±0   14m 54s ⏱️ -13s
897 tests ±0  897 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
903 runs  ±0  903 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a8a7f6f. ± Comparison against base commit 969ecaa.

@skjindal93
Copy link
Copy Markdown
Contributor

skjindal93 commented May 3, 2021

Did we change it to false recently?

Actually, it has been false since long time. That change happened post launch. I think @arjunlalb , @aaron-steinfeld or @skjindal93 might have some additional context here.

We changed it to false, because we felt that the interval selector was overcrowding the cartesians in overview and home dashboards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandtiwary anandtiwary anandtiwary approved these changes

@itssharmasandeep itssharmasandeep itssharmasandeep approved these changes

@arjunlalb arjunlalb Awaiting requested review from arjunlalb

@skjindal93 skjindal93 Awaiting requested review from skjindal93

@kotharironak kotharironak Awaiting requested review from kotharironak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Metrics are showing in a bucket of 15 seconds

4 participants

@JBAhire @skjindal93 @anandtiwary @itssharmasandeep