Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

chore: added code style#85

Merged
skjindal93 merged 2 commits intomainfrom
add+code+style
Apr 5, 2021
Merged

chore: added code style#85
skjindal93 merged 2 commits intomainfrom
add+code+style

Conversation

@skjindal93
Copy link
Copy Markdown
Contributor

@skjindal93 skjindal93 commented Apr 5, 2021

Description

Added code style

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2021

Codecov Report

Merging #85 (dbd3102) into main (e922748) will increase coverage by 0.08%.
The diff coverage is 76.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #85      +/-   ##
============================================
+ Coverage     77.00%   77.08%   +0.08%     
  Complexity     1082     1082              
============================================
  Files           105      105              
  Lines          4848     4884      +36     
  Branches        414      416       +2     
============================================
+ Hits           3733     3765      +32     
- Misses          932      936       +4     
  Partials        183      183
Flag Coverage Δ Complexity Δ
unit 77.08% <76.22%> (+0.08%) 0.00 <31.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...e/gateway/service/baseline/BaselineCalculator.java 88.88% <ø> (ø) 8.00 <0.00> (ø)
...ice/baseline/BaselineEntitiesRequestValidator.java 71.42% <ø> (ø) 6.00 <0.00> (ø)
...teway/service/baseline/BaselineRequestContext.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
.../gateway/service/baseline/BaselineServiceImpl.java 97.47% <ø> (ø) 34.00 <0.00> (ø)
...service/baseline/BaselineServiceQueryExecutor.java 80.00% <ø> (ø) 1.00 <0.00> (ø)
...ce/gateway/service/common/QueryRequestContext.java 61.53% <0.00%> (-8.03%) 9.00 <0.00> (ø)
...ertrace/gateway/service/common/RequestContext.java 63.63% <0.00%> (+5.30%) 4.00 <0.00> (ø)
.../service/common/comparators/OrderByComparator.java 85.00% <ø> (ø) 8.00 <0.00> (ø)
...rters/EntityServiceAndGatewayServiceConverter.java 32.25% <0.00%> (ø) 19.00 <0.00> (ø)
...vice/common/datafetcher/EntityFetcherResponse.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e922748...dbd3102. Read the comment docs.

@github-actions

This comment has been minimized.

Sign in to view
@skjindal93 skjindal93 merged commit 4cd2977 into main Apr 5, 2021
@skjindal93 skjindal93 deleted the add+code+style branch April 5, 2021 15:45
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2021

Unit Test Results

  54 files  ±0    54 suites  ±0   6s ⏱️ -2s
314 tests ±0  314 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4cd2977. ± Comparison against base commit e922748.

@jcchavezs
Copy link
Copy Markdown

jcchavezs commented Apr 6, 2021

I think a next step here would be to fail the CI if the code style isn't met.

@skjindal93
Copy link
Copy Markdown
Contributor Author

skjindal93 commented Apr 6, 2021

I think a next step here would be to fail the CI if the code style isn't met.

The code style plugin automatically takes care of it. It runs code style checks as part of gradle build step

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kotharironak kotharironak Awaiting requested review from kotharironak

@tim-mwangi tim-mwangi Awaiting requested review from tim-mwangi

1 more reviewer

@avinashkolluru avinashkolluru avinashkolluru approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skjindal93 @jcchavezs @avinashkolluru