Skip to content

fix codeowners#118

Merged
skjindal93 merged 1 commit intomainfrom
fix+codeowers
Jul 29, 2021
Merged

fix codeowners#118
skjindal93 merged 1 commit intomainfrom
fix+codeowers

Conversation

@skjindal93
Copy link
Copy Markdown
Contributor

No description provided.

@skjindal93 skjindal93 requested a review from a team as a code owner July 29, 2021 11:34
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 29, 2021

Codecov Report

Merging #118 (cfb4659) into main (5a603cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #118   +/-   ##
=========================================
  Coverage     59.77%   59.77%           
  Complexity      295      295           
=========================================
  Files            39       39           
  Lines          2978     2978           
  Branches        368      368           
=========================================
  Hits           1780     1780           
  Misses         1026     1026           
  Partials        172      172           
Flag Coverage Δ
integration 59.77% <ø> (ø)
unit 39.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a603cc...cfb4659. Read the comment docs.

@github-actions

This comment has been minimized.

@skjindal93 skjindal93 merged commit 1f8c1a9 into main Jul 29, 2021
@skjindal93 skjindal93 deleted the fix+codeowers branch July 29, 2021 11:40
@github-actions
Copy link
Copy Markdown

Unit Test Results

  30 files  ±0    30 suites  ±0   18s ⏱️ ±0s
141 tests ±0  141 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1f8c1a9. ± Comparison against base commit 5a603cc.


# global
* @hypertrace/config-services-owners
* @hypertrace/query-layer-owners
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This service can really go either way, it's both query and config - I'm fine either way, though.

suddendust pushed a commit to suddendust/entity-service that referenced this pull request Sep 5, 2025
* Add and implement the atomic read and write sub docs API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants