Skip to content

Renames label service to labels service. Also start labels service as part of config service startup.#52

Merged
saxenakshitiz merged 7 commits intomainfrom
ENG-11219_1
Aug 27, 2021
Merged

Renames label service to labels service. Also start labels service as part of config service startup.#52
saxenakshitiz merged 7 commits intomainfrom
ENG-11219_1

Conversation

@saxenakshitiz
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2021

Codecov Report

Merging #52 (6b9bffc) into main (e84f734) will decrease coverage by 1.06%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #52      +/-   ##
============================================
- Coverage     92.04%   90.97%   -1.07%     
  Complexity      137      137              
============================================
  Files            16       16              
  Lines           553      565      +12     
  Branches         24       27       +3     
============================================
+ Hits            509      514       +5     
- Misses           37       41       +4     
- Partials          7       10       +3     
Flag Coverage Δ
integration 90.97% <73.33%> (-1.07%) ⬇️
unit 89.72% <73.91%> (-1.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pertrace/config/service/ConfigServicesFactory.java 58.33% <0.00%> (-5.31%) ⬇️
.../label/config/service/LabelsConfigServiceImpl.java 90.10% <68.42%> (ø)
...a/org/hypertrace/config/service/ConfigService.java 75.67% <100.00%> (+1.38%) ⬆️
...l/config/service/ConfigServiceCoordinatorImpl.java 95.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e84f734...6b9bffc. Read the comment docs.

@github-actions

This comment has been minimized.

@saxenakshitiz saxenakshitiz merged commit 5b69784 into main Aug 27, 2021
@saxenakshitiz saxenakshitiz deleted the ENG-11219_1 branch August 27, 2021 07:07
@github-actions
Copy link
Copy Markdown

Unit Test Results

11 files  ±0  11 suites  ±0   8s ⏱️ ±0s
42 tests ±0  42 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5b69784. ± Comparison against base commit e84f734.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants