Skip to content

new icon: msbuild (original, plain, line)#2662

Open
MattKotsenas wants to merge 2 commits intodevicons:developfrom
MattKotsenas:add-msbuild-icon
Open

new icon: msbuild (original, plain, line)#2662
MattKotsenas wants to merge 2 commits intodevicons:developfrom
MattKotsenas:add-msbuild-icon

Conversation

@MattKotsenas
Copy link

@MattKotsenas MattKotsenas commented Feb 9, 2026

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://github.com/dotnet/msbuild/tree/main/branding

weh
weh requested changes Feb 25, 2026
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MattKotsenas thanks for your contribution.
i have only one thing i like to change. To me the line version has two lines that are wider than the others. I guess that is caused by two parallel lines.

Can you try to fix that, so that those lines look the same as all others?

Image

@weh weh added the feature:icon PR when a new icon is ready to be added to the collection label Feb 25, 2026
@MattKotsenas MattKotsenas force-pushed the add-msbuild-icon branch 3 times, most recently from 53a95e1 to 8658f5a Compare February 25, 2026 21:03
@MattKotsenas
new icon: msbuild (original, plain, line)
0f06558
@MattKotsenas
Fix msbuild line icon: uniform stroke width for internal division lines
fbd63f6 
Previously the internal facet division lines appeared double-width
because
the line icon was generated by stroking the plain path (which has gaps).
Fixed by stroking each original face path individually and unioning
them,
so shared edges merge naturally into single-width lines.
@MattKotsenas
Copy link
Author

MattKotsenas commented Feb 25, 2026

@weh, fixed! Would you mind taking another look and letting me know if anything else looks incorrect? Thanks so much for your help!

weh
weh approved these changes Feb 26, 2026
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, looks good to me

@weh weh added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels Feb 26, 2026
@weh weh requested review from a team, Snailedlt, canaleal and lunatic-fox and removed request for a team February 26, 2026 09:30
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weh weh weh approved these changes

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal canaleal was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees

No one assigned

Labels

bot:check Trigger check-bot. Remove and re-add the label to re-trigger bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MattKotsenas @weh