fixed exception handling of ksql#81
Merged
bryanyang0528 merged 1 commit intobryanyang0528:masterfrom Aug 25, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 74.65% 74.65%
=======================================
Files 7 7
Lines 363 363
Branches 48 48
=======================================
Hits 271 271
Misses 77 77
Partials 15 15
Continue to review full report at Codecov.
|
Owner
|
@bbkchdhry Thanks. That's exactly what I would like to fix too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
I am using ksql 0.10.1.1 version and it doesn't throw any error if I execute a wrong command.
But for the same code with previous ksql version 0.5.1.1 it shows the error.
My Code:
Error from ksql: 0.5.1.1
Result from ksql: 0.10.1.1
So, I have modified the code a little and now the exception handling is working fine.
