Skip to content

feat: expose staged and take_staged on Wallet #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reez merged 1 commit into from
Oct 20, 2025
Merged

feat: expose staged and take_staged on Wallet #885

reez merged 1 commit into from
Oct 20, 2025

Conversation

@reez
Copy link
Collaborator

@reez reez commented Oct 14, 2025 •
edited
Loading

Description

Useful for anything from logging+diagnostics to custom persistence

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez requested a review from thunderbiscuit October 14, 2025 20:20
@ItoroD
Copy link
Collaborator

ItoroD commented Oct 15, 2025

Looks good! Small question, at what point does staged get updated with values? Something like revealing an address should do that according to doc for Changeset. I tried this on android and I get null/empty values for all stage fields.

@reez
Copy link
Collaborator Author

reez commented Oct 15, 2025

Looks good! Small question, at what point does staged get updated with values? Something like revealing an address should do that according to doc for Changeset. I tried this on android and I get null/empty values for all stage fields.

Good q, after you reveal an address take a look at the staged ChangeSet's indexer_changeset().last_revealed which should show an updated descriptor id and the new derivation index I believe

thunderbiscuit
thunderbiscuit approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b022465

@reez reez merged commit fffe28a into bitcoindevkit:master Oct 20, 2025
6 checks passed
@reez reez deleted the take branch October 20, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

BDK-Bindings
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reez @ItoroD @thunderbiscuit