This change is under the idea of libraries should provide errors not crashes, but I'm totally open to feedback.

This is exactly the right idea, which is why I'd strongly be in favor of fixing the panics in bdk_esplora directly, instead of patching it up only for bindings users here. See related issue bitcoindevkit/bdk_wallet#30.

This change is under the idea of libraries should provide errors not crashes, but I'm totally open to feedback.

This is exactly the right idea, which is why I'd strongly be in favor of fixing the panics in bdk_esplora directly, instead of patching it up only for bindings users here. See related issue bitcoindevkit/bdk_wallet#30.

thanks so much for this feedback @tnull !

And thank you for pointing me towards that open issue! I'll hop on there with a comment too.

I thought as well about the ideal ultimate solution being it is addressed in bdk_esplora directly, so while I was making this bdk-ffi PR yesterday I also made a small branch with that change to test it out in bdk_esplora reez/bdk@823fdf2 ... I wanted to sit on it for the night because I wasn't totally sure if it was the right direction (or the exact right/all-encompassing code), but based on my initial impulse and then your feedback now the general direction of addressing the issue ultimately in bdk_esplora seems right.

(For anyone reviewing this on bdk-ffi I still think it has merit being merged now while we work towards getting a solution in bdk_esplora eventually)

I'm happy to merge this while we wait for the fixes to appear upstream. Your call @reez. Depends on how close you think we are to merging the fix directly in the Rust clients.

with https://github.com/bitcoindevkit/bdk_wallet/releases/tag/wallet-2.2.0 released and ffi following on pretty quick with our release I think this going into our 2.2 would make sense. I also just opened a pr on upstream to potentially remove any other panics.

I should rebase this and it should be ready

rebased

ACK 58c425b.

Would you mind opening an issue reminding us to fix this up whenever the fixes are merged upstream?

Totally, I was actually thinking about opening up issues for future releases to track what we want to test/implement/track, so I opened one up for 3.0/2.3 #869 (and added this as the first item)