This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixed t3c for layered profile order issue#7425
Merged
zrhoffman merged 4 commits intoapache:masterfrom Mar 31, 2023
Merged
Conversation
traeak
approved these changes
Mar 31, 2023
Contributor
traeak
left a comment
There was a problem hiding this comment.
These fixes look good and just reverse the profile evaluation (not that i like the back to front eval but that ship has sailed).
Codecov Report
@@ Coverage Diff @@
## master #7425 +/- ##
============================================
+ Coverage 27.03% 27.04% +0.01%
Complexity 98 98
============================================
Files 685 685
Lines 77279 77301 +22
Branches 90 90
============================================
+ Hits 20892 20908 +16
- Misses 54399 54405 +6
Partials 1988 1988
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when layered profiles are used, t3c was not iterating through the profiles in the proper order,
which was causing duplicate parameters to be incorrectly overridden
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
run the unit test for layered profiles, otherwise build and install t3c setup layered profiles on a cache and
have 2 or more parameters with the same config file and name but different values. run t3c and verify
duplicate parameters have been overridden by the profile with the highest priority.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist