sheetjs/sheetjs
72
Fork 62
Code Issues 208 Pull Requests 14 Wiki Activity

Read + write style information to .xlsx #263

Open
protobi wants to merge 104 commits from protobi/master into master
pull from: protobi/master
merge into: sheetjs:master
Conversation 26 Commits 104 Files Changed 47 +9611 -1419
protobi commented 2015-06-24 15:40:52 +00:00 (Migrated from github.com)
Copy Link

A collective series of changes that allows style information to be read from and written to xlsx files. This should not affect .xls or .xlsb files.

Submitting a pull request so that the option to merge the changes exists. Am open to additional steps to harmonize this with the rest of the lib if required.

A collective series of changes that allows style information to be read from and written to xlsx files. This should not affect .xls or .xlsb files. Submitting a pull request so that the option to merge the changes exists. Am open to additional steps to harmonize this with the rest of the lib if required.
👍 10
SheetJSDev commented 2015-06-26 15:33:03 +00:00 (Migrated from github.com)
Copy Link

@protobi check your email.

We're gonna squash, so don't worry about the commit log for the moment. Taking a quick scan at the changed files (https://github.com/SheetJS/js-xlsx/pull/263/files?diff=unified click on "changed files"):

  • I just noticed you added some files .DS_Store and .idea/scopes/scope_settings which should be removed (probably should add .DS_Store and .idea/ to the .gitignore
  • Should the lab directory also be ignored?
  • Can you move the new test files (test-*.js as well as supporting files like out.txt) to the tests subdirectory? We can blow away the old jasmine tests
  • I'm not sure whether the example files should be put in the misc folder or in a separate samples directory. Thoughts?
@protobi check your email. We're gonna squash, so don't worry about the commit log for the moment. Taking a quick scan at the changed files (https://github.com/SheetJS/js-xlsx/pull/263/files?diff=unified click on "changed files"): - I just noticed you added some files .DS_Store and .idea/scopes/scope_settings which should be removed (probably should add .DS_Store and .idea/ to the .gitignore - Should the lab directory also be ignored? - Can you move the new test files (test-*.js as well as supporting files like out.txt) to the tests subdirectory? We can blow away the old jasmine tests - I'm not sure whether the example files should be put in the misc folder or in a separate samples directory. Thoughts?
protobi commented 2015-06-26 17:16:40 +00:00 (Migrated from github.com)
Copy Link

Files now removed from the repo, these had earlier been inadvertently added.

Files now removed from the repo, these had earlier been inadvertently added.
rclai commented 2015-06-29 16:50:33 +00:00 (Migrated from github.com)
Copy Link

This is awesome!

This is awesome!
rclai commented 2015-06-29 16:54:54 +00:00 (Migrated from github.com)
Copy Link

@protobi are you able to mention in the docs that you need to put cell styles inside the s property before being encoded? I was having hard time figuring out why my styles weren't showing up.

@protobi are you able to mention in the docs that you need to put cell styles inside the `s` property before being encoded? I was having hard time figuring out why my styles weren't showing up.
protobi commented 2015-06-29 23:28:48 +00:00 (Migrated from github.com)
Copy Link

@rclai Thanks for beta testing the docs and providing that feedback. Will edit this docs later this week.

@rclai Thanks for beta testing the docs and providing that feedback. Will edit this docs later this week.
chrismatheson commented 2015-07-20 14:53:11 +00:00 (Migrated from github.com)
Copy Link

👍 this was a great help to find thanks @protobi . Modifying without changing styling was a must have for my project.

any chance this will be merged?

:+1: this was a great help to find thanks @protobi . Modifying without changing styling was a must have for my project. any chance this will be merged?
willgriffin commented 2017-03-13 20:28:49 +00:00 (Migrated from github.com)
Copy Link

how exciting, renewed activity means this has finally has a chance of being pulled in i hope

how exciting, renewed activity means this has finally has a chance of being pulled in i hope
👍 3
SheetJSDev commented 2017-03-19 07:03:21 +00:00 (Migrated from github.com)
Copy Link

We're slowly picking changes. The first commit, credited to @protobi, fills out some holes in the xml style parsing. It won't show up in the github UI as a merge but it will credit you as a contributor.

We're slowly picking changes. The first commit, credited to @protobi, fills out some holes in the xml style parsing. It won't show up in the github UI as a merge but it will credit you as a contributor.
👍 2
SheetJSDev commented 2017-04-10 18:29:24 +00:00 (Migrated from github.com)
Copy Link

Instead of hardcoding the specific property overrides, the writer now takes a Props key in the options object and uses those instead of the workbook properties. It's explained in the README, but it boils down to the following changes:

this fork main repo
"title" "Title"
"subject" "Subject"
"description" "Comments"
"keywords" "Keywords"
"creator" "Author"

The mapping from the XLSX name to the CSF name is in the CORE_PROPS variable in bits/33_coreprops.js.

Instead of hardcoding the specific property overrides, the writer now takes a `Props` key in the options object and uses those instead of the workbook properties. It's explained [in the README](https://github.com/SheetJS/js-xlsx#workbook-file-properties), but it boils down to the following changes: | this fork | main repo | |-----------------|:-------------| | `"title"` | `"Title"` | | `"subject"` | `"Subject"` | | `"description"` | `"Comments"` | | `"keywords"` | `"Keywords"` | | `"creator"` | `"Author"` | The mapping from the XLSX name to the CSF name is in the `CORE_PROPS` variable in `bits/33_coreprops.js`.
SheetJSDev commented 2017-04-17 02:14:19 +00:00 (Migrated from github.com)
Copy Link

the theme override is now passed with the themeXLSX option. themeXml is ambiguous since multiple formats use xml-based themes, so calling it themeXLSX makes it clear we are talking about pass-through XLSX-style themes.

the theme override is now passed with the `themeXLSX` option. `themeXml` is ambiguous since multiple formats use xml-based themes, so calling it `themeXLSX` makes it clear we are talking about pass-through XLSX-style themes.
vedant05 commented 2017-06-14 12:52:32 +00:00 (Migrated from github.com)
Copy Link

Can anyone send me the codes to convert excel(xlsx) file to json file in java script with explanation to vedantkumar05@gmail.com

Can anyone send me the codes to convert excel(xlsx) file to json file in java script with explanation to vedantkumar05@gmail.com
👎 3
Yugam18 commented 2017-06-20 12:08:47 +00:00 (Migrated from github.com)
Copy Link

@SheetJSDev ,when this PR will get merged ?
I am waiting for its new release with the support of style.

@SheetJSDev ,when this PR will get merged ? I am waiting for its new release with the support of style.
👍 35
125037225 commented 2018-01-29 07:40:20 +00:00 (Migrated from github.com)
Copy Link

When to merge into master?I need it super. Support！

When to merge into master?I need it super. Support！
👍 10 👎 1
zenbaku commented 2018-02-14 16:49:19 +00:00 (Migrated from github.com)
Copy Link

Need this too! Hopefully it will be merged soon 🙏

Need this too! Hopefully it will be merged soon 🙏
❤️ 3
estrellajm commented 2018-03-18 20:37:31 +00:00 (Migrated from github.com)
Copy Link

@SheetJSDev, can you please advise as to when this will get merged? I need to style & format the cells.

@SheetJSDev, can you please advise as to when this will get merged? I need to style & format the cells.
👍 17
benjaminaudet commented 2018-05-03 08:22:23 +00:00 (Migrated from github.com)
Copy Link

Hi @SheetJSDev, when this PR will be merged with master branch ?
Thanks you

Hi @SheetJSDev, when this PR will be merged with master branch ? Thanks you
👍 2
minecrawler commented 2019-01-23 18:22:05 +00:00 (Migrated from github.com)
Copy Link

BUMP! This is quite an important feature for us, is it possible to merge it soon @protobi @SheetJSDev ? Do you need any help in order to speed up the process? This PR has been open for far too long.

BUMP! This is quite an important feature for us, is it possible to merge it soon @protobi @SheetJSDev ? Do you need any help in order to speed up the process? This PR has been open for far too long.
👍 1
kirillgroshkov commented 2019-05-15 15:31:15 +00:00 (Migrated from github.com)
Copy Link

Important for us too

Important for us too
👍 1
nakshay (Migrated from github.com) approved these changes 2019-06-11 08:25:42 +00:00
ralph-dev commented 2020-02-26 20:30:10 +00:00 (Migrated from github.com)
Copy Link

Any luck on merging everything?

Any luck on merging everything?
👍 1
nakshay commented 2020-02-27 06:35:57 +00:00 (Migrated from github.com)
Copy Link

I don't have any idea why I am in reviewer list, @SheetJSDev can you please check this.

I don't have any idea why I am in reviewer list, @SheetJSDev can you please check this.
kachkaev commented 2020-02-27 08:07:38 +00:00 (Migrated from github.com)
Copy Link

@nakshay here is the answer 🙂

Screenshot 2020-02-27 at 08 07 00
@nakshay here is the answer 🙂 <img width="749" alt="Screenshot 2020-02-27 at 08 07 00" src="/?originalUrl=https%3A%2F%2Fgit.sheetjs.com%2F%26%2334%3Bhttps%3A%2F%2Fuser-images.githubusercontent.com%2F608862%2F75424252-2f032f80-5938-11ea-9ed6-d45ab00fe869.png%26%2334%3B%26gt%3B%253C%2Fdiv">
nakshay commented 2020-02-27 10:04:42 +00:00 (Migrated from github.com)
Copy Link

@nakshay here is the answer 🙂

Screenshot 2020-02-27 at 08 07 00

Yeh embarrassing , happened by mistake, and not able to find way to undo it .

> @nakshay here is the answer 🙂 > > <img alt="Screenshot 2020-02-27 at 08 07 00" width="749" src="/?originalUrl=https%3A%2F%2Fgit.sheetjs.com%2F%26%2334%3Bhttps%3A%2F%2Fuser-images.githubusercontent.com%2F608862%2F75424252-2f032f80-5938-11ea-9ed6-d45ab00fe869.png%26%2334%3B%26gt%3BYeh%2520embarrassing%2520%2C%2520happened%2520by%2520mistake%2C%2520and%2520not%2520able%2520to%2520find%2520way%2520to%2520undo%2520it%2520.%253C%2Fdiv">
semaurer commented 2020-03-06 21:31:38 +00:00 (Migrated from github.com)
Copy Link

Any updates on this PR?

Any updates on this PR?
👍 10
cjtafoya commented 2020-11-18 04:01:45 +00:00 (Migrated from github.com)
Copy Link

Annual bump... 5 years later, still would be useful.

Annual bump... 5 years later, still would be useful.
👀 2 😆 6
sadortun commented 2021-01-11 03:16:31 +00:00 (Migrated from github.com)
Copy Link

@cjtafoya 😆

Annual bump... 6 years later, still would be useful.

@cjtafoya 😆 > Annual bump... 6 years later, still would be useful.
👍 4
JulianNicholls commented 2022-01-20 15:54:41 +00:00 (Migrated from github.com)
Copy Link

This is vital to me to be able to use the library.

This is vital to me to be able to use the library.
This pull request has changes conflicting with the target branch.
  • .gitignore
  • README.md
  • bits/01_version.js
  • bits/21_ziputils.js
  • bits/33_coreprops.js
  • bits/45_styutils.js
  • bits/47_styxml.js
  • bits/49_theme.js
  • bits/66_wscommon.js
  • bits/67_wsxml.js
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin protobi/master:protobi/master
git checkout protobi/master

Merge

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff protobi/master
git checkout master
git merge --ff-only protobi/master
git checkout protobi/master
git rebase master
git checkout master
git merge --no-ff protobi/master
git checkout master
git merge --squash protobi/master
git checkout master
git merge --ff-only protobi/master
git checkout master
git merge protobi/master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
nakshay
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#263
No description provided.
Delete Branch "protobi/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?