[FWaaS] Remove client side protocol validation

There is no need to limit available choices for the firewall rule's protocol on the client side. Neutron-fwaas plugin on the server side will do the validation in the same way as for security group rules. And for SG rules OSC is not validating nor limiting choices on the client's side at all. Closes-bug: #2142479 Change-Id: I8c02a2232601c2ab6655c458aa0365102b3b5e2d Signed-off-by: Slawek Kaplonski <skaplons@redhat.com>
Bump flake8-import-order
2026-02-23 16:57:58 +01:00 · 2026-02-21 00:18:54 +09:00 · 2025-12-12 17:29:15 +00:00 · 2025-11-11 14:05:44 -05:00 · 2025-11-06 21:39:01 +00:00 · 2025-10-31 12:06:40 +00:00
8 changed files with 15 additions and 7 deletions
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -31,7 +31,6 @@
      - openstack/keystoneauth
      - openstack/neutron
      - openstack/neutron-lib
-      - openstack/os-client-config
      - openstack/python-cinderclient
      - openstack/python-glanceclient
      - openstack/python-ironicclient
--- a/neutronclient/osc/v2/fwaas/firewallrule.py
+++ b/neutronclient/osc/v2/fwaas/firewallrule.py
@@ -86,9 +86,12 @@ def _get_common_parser(parser):
        help=_('Description of the firewall rule'))
    parser.add_argument(
        '--protocol',
-        choices=['tcp', 'udp', 'icmp', 'any'],
        type=nc_utils.convert_to_lowercase,
-        help=_('Protocol for the firewall rule'))
+        help=_('IP protocol (ah, dccp, egp, esp, gre, icmp, igmp, '
+               'ipv6-encap, ipv6-frag, ipv6-icmp, ipv6-nonxt, ipv6-opts, '
+               'ipv6-route, ospf, pgm, rsvp, sctp, tcp, udp, udplite, '
+               'vrrp and integer representations [0-255] or any; '
+               'default: any (all protocols))'))
    parser.add_argument(
        '--action',
        choices=['allow', 'deny', 'reject'],
--- a/neutronclient/v2_0/client.py
+++ b/neutronclient/v2_0/client.py
@@ -850,7 +850,7 @@ class Client(ClientBase):

    def list_port_bindings(self, port_id, retrieve_all=True, **_params):
        """Fetches a list of all bindings for a certain port."""
-        return self.list('port_bindings', self.port_bindings_path % port_id,
+        return self.list('bindings', self.port_bindings_path % port_id,
                         retrieve_all, **_params)

    def activate_port_binding(self, port_id, host_id):
--- a/releasenotes/source/2024.1.rst
+++ b/releasenotes/source/2024.1.rst
@@ -3,4 +3,4 @@
 ===========================

 .. release-notes::
-   :branch: stable/2024.1
+   :branch: unmaintained/2024.1
--- a/releasenotes/source/2025.2.rst
+++ b/releasenotes/source/2025.2.rst
@@ -0,0 +1,6 @@
+===========================
+2025.2 Series Release Notes
+===========================
+
+.. release-notes::
+   :branch: stable/2025.2
--- a/releasenotes/source/index.rst
+++ b/releasenotes/source/index.rst
@@ -6,6 +6,7 @@
   :maxdepth: 1

   unreleased
+   2025.2
   2025.1
   2024.2
   2024.1
--- a/requirements.txt
+++ b/requirements.txt
@@ -11,7 +11,6 @@ oslo.i18n>=3.15.3 # Apache-2.0
 oslo.log>=3.36.0 # Apache-2.0
 oslo.serialization!=2.19.1,>=2.18.0 # Apache-2.0
 oslo.utils>=3.33.0 # Apache-2.0
-os-client-config>=1.28.0 # Apache-2.0
 keystoneauth1>=3.8.0 # Apache-2.0
 # keystoneclient is used only by neutronclient.osc.utils
 # TODO(amotoki): Drop this after osc.utils has no dependency on keystoneclient
--- a/test-requirements.txt
+++ b/test-requirements.txt
@@ -3,7 +3,7 @@ hacking>=6.1.0,<6.2.0 # Apache-2.0
 bandit!=1.6.0,>=1.1.0 # Apache-2.0
 coverage!=4.4,>=4.0 # Apache-2.0
 fixtures>=3.0.0 # Apache-2.0/BSD
-flake8-import-order>=0.18.0,<0.19.0 # LGPLv3
+flake8-import-order>=0.19.0,<0.20.0 # LGPLv3
 oslotest>=3.2.0 # Apache-2.0
 osprofiler>=2.3.0 # Apache-2.0
 python-openstackclient>=3.12.0 # Apache-2.0
Author	SHA1	Message	Date
Slawek Kaplonski	f7c085005d	[FWaaS] Remove client side protocol validation There is no need to limit available choices for the firewall rule's protocol on the client side. Neutron-fwaas plugin on the server side will do the validation in the same way as for security group rules. And for SG rules OSC is not validating nor limiting choices on the client's side at all. Closes-bug: #2142479 Change-Id: I8c02a2232601c2ab6655c458aa0365102b3b5e2d Signed-off-by: Slawek Kaplonski <skaplons@redhat.com>	2026-02-23 16:57:58 +01:00
Takashi Kajinami	d9a3518f75	Bump flake8-import-order The 1.18.2 release requires pkg_resources. The dependency was removed in 1.19.0 . Change-Id: I25106085e68dfc13a091af0e9e365287dac17308 Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>	2026-02-21 00:18:54 +09:00
Zuul	efa0ccb944	Merge "Revert "Add Tap-as-a-Service client code""	2025-12-12 17:29:15 +00:00
Zhan Zhang	8f72d77812	v2_0: Use 'bindings' when listing port bindings This commit fixes a bug in v2_0 client's "list_port_bindings" function, where it uses "port_bindings" to access Neutron's response, instead of "bindings" [0]. [0]: https://docs.openstack.org/api-ref/network/v2/index.html#show-port-binding-of-a-port Closes-Bug: #2130459 Change-Id: I32ef753ec212b55f698e3844e043f68b22992ead Signed-off-by: Zhan Zhang <zzhang953@bloomberg.net>	2025-11-11 14:05:44 -05:00
Miro Tomaska	a991ac87c7	Revert "Add Tap-as-a-Service client code" This reverts commit `01ffc4684a`. Reason for revert: In the last PTG we decided that the best location for the stadium projects osc client code would be the openstackclient repo. A patch was proposed for tapaas, see depends-on link below. Other projects will follow Change-Id: Iaad2080f0ef552a0c0a00635bea48130cfc327a4 Depends-On: https://review.opendev.org/c/openstack/python-openstackclient/+/963445 Signed-off-by: Miro Tomaska <mtomaska@redhat.com>	2025-11-06 21:39:01 +00:00
OpenStack Release Bot	01d0553ca4	reno: Update master for unmaintained/2024.1 Update the 2024.1 release notes configuration to build from unmaintained/2024.1. Change-Id: Ic2592d22b36b22f3cf48a21d81bfb0b41b31ae86 Signed-off-by: OpenStack Release Bot <infra-root@openstack.org> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/change_reno_branch_to_unmaintained.sh	2025-10-31 12:06:40 +00:00
Zuul	66ccb4569d	Merge "Add Tap-as-a-Service client code"	2025-09-19 16:22:01 +00:00
Zuul	1aee34b246	Merge "Drop unused os-client-config"	2025-09-15 20:36:02 +00:00
Mohammed Naser	01ffc4684a	Add Tap-as-a-Service client code This commit adds the Tap-as-a-Service client code as-is based on the discussion that it can now be included into the Neutron client[1]. [1]: https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/PCITF3UPLEEVQB7EVJ2MB6FLAI3RFYSR/ Change-Id: I82b3229b3f9ac7ef57324d0a611527c77d26c3b6 Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>	2025-09-12 11:37:06 -04:00
OpenStack Release Bot	2f170ce6aa	Update master for stable/2025.2 Add file to the reno documentation build to show release notes for stable/2025.2. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/2025.2. Sem-Ver: feature Change-Id: I97f7bba4f875b98d98f03ba60ee394a1aa64a3fd Signed-off-by: OpenStack Release Bot <infra-root@openstack.org> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/add_release_note_page.sh	2025-09-04 13:44:40 +00:00
Takashi Kajinami	275924ecc8	Drop unused os-client-config It was deprecated[1] after the code was merged into openstacksdk[2]. It's not actually used by any code in this repository. [1] https://review.opendev.org/c/openstack/os-client-config/+/549307 [2] https://review.opendev.org/c/openstack/openstacksdk/+/518128 Change-Id: Ia93d2952ca09fc70a970a85789775441ed114d49 Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>	2025-07-02 23:23:28 +09:00