Remove all cinderclient.v2 classes, mostly incorporating them into
their v3 counterparts and updating the tests and test fixtures.
Depends-on: https://review.opendev.org/c/openstack/horizon/+/800814
Change-Id: I335db5c1799edb2273bf8bfc9e1bc9de404a4ba5
Cinder and cinderclient assumes an attachment create request will
always contain instance_uuid. This is not true when glance calls
cinder for attachment in glance cinder configuration.
This patch (along with the cinder patch) make the instance_uuid
optional and allow glance to do attachments without passing
instance_uuid.
Change-Id: Ifbaca4aa87d890bc5130069638d42665b914b378
Also removes the v2 support from the generic client and restores a
skipped test.
Additionally, the cinderclient.tests.v2.test_availablity_zone module
depends on the v2.shell class, so move that module to v3, update the
v3 AvailablityZone class, and make appropriate adjustments to the
tests and test fixtures.
Change-Id: I7a3cca15f5944141d510a75af6684221c297963b
This prevents a job reporting 'success' when the appropriate python
interpreter cannot be found, when actually it didn't run at all.
Also change the default envlist to use generic 'py3' instead of a
specific version which might not be present.
Also change zuul config so the python-cinderclient-functional-py36
job runs on centos-8-stream nodes, where py36 should be available.
And change bindep.txt to specify the correct package name for
centos-8.
Jeremy Stanley has given a more thorough explanation of why this
is a good change:
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014810.html
This isn't a theoretical issue. If you look at recent
python-cinderclient-functional-py36 job results (for example,
[0]), you'll see that Zuul reported 'success', but on a closer look,
you'll see that no tests were run.
[0] https://zuul.opendev.org/t/openstack/build/1bfc80638086405f8b29905cdd6f71be/log/job-output.txt#25470
Change-Id: I2e2aa24e1592b66b287c84eda97b5079c40a36ec
Devstack is planning to remove the Ubuntu
Bionic support.
- https://review.opendev.org/c/openstack/devstack/+/788754
Before that we need to switch Bionic job to focal.
devstack-tox-functional define the latest nodeset which is
single node focal currently so removing nodeset setting from
python-cinderclient functional jobs.
Change-Id: Ibbbfb20c86bb2ea0d3d74f6a6a1bc913874f67ad
Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:
UserWarning: Usage of dash-separated 'description-file' will not be
supported in future versions. Please use the underscore name
'description_file' instead
[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb
Change-Id: I77d52471fea255982ad677e9d4bc318f24a9ace7
Add file to the reno documentation build to show release notes for
stable/wallaby.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/wallaby.
Sem-Ver: feature
Change-Id: I7a9c0cd51c45f05c75d3fa5be137aad7e62a016c
Updates requirements to what we're using now and revises the
lower-constraints file to contain only direct dependencies.
Change-Id: I1a3cc999b94dc6b6482b1ca44218b42ee2638a8c
In python 3, all strings are considered as unicode string.
This patch drops the explicit unicode literal (u'...')
or (u"..") appearances from the unicode strings.
Change-Id: I9902966892a1dc4f85d449dfe580fb128647487b
This adds the import order extension to match what we have in the cinder
repo. This is a linting extension that will check that imports are in
the correct order and the correct grouping so they automatically get
flagged, and it won't be whether reviewers notice and decide to do
anything or not.
Cinder change was Ic13ba238a4a45c6219f4de131cfe0366219d722f for a little
more wordy reasoning.
Also includes updates for noqa tags. Newer version of the linters appear
to want these on the function definition line, not on the decorator
line.
Change-Id: Ibf3f3afbf3bb6ec6613b35f91d4a353c6a391f41
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Bump MAX_VERSION to 3.64 to support including the encryption_key_id
attribute in volume and backup details.
Implements: blueprint include-encryption-key-id-in-details
Depends-On: I16f54e6722cdbcbad4af1eb0d30264b0039412fd
Change-Id: I6e1f3ff62d4b7b9b8299f7bd73071c3c7856f6df
Using the cinderclient to fetch server versions will fail with error
`OpenSSL.SSL.Error: [sslv3 alert handshake failure]` when the server
requires client certificates to be passed with these requests.
Added the optional parameter `cert` to both get_server_version
get_highest_client_server_version and methods so that users can have
the option to pass client certificates while fetching server versions.
Also support passing mTLS certificate/key to HTTPClient
Closes-Bug: #1915996
Change-Id: I57c665dd9d4b8c32e5f10994d891d1e0f5315548
Signed-off-by: sri harsha mekala <smekala@oath.com>
The current version does not work anymore with the current
testing stack.
Due to the bump, the wrapper needed a few changes
(maybe it could be dropped at some point?
Version 2.3.0 (used by cinder right now) was considered too,
but it requires a specific version of isort:
https://github.com/PyCQA/isort/issues/1273
Change-Id: I07fa32e7f49bde041d101a2d09860d0bc27acda0
The docs requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.
Change-Id: I94c2ba1ddfc3a54edc2f69b8d7017e09b02e54a5
During the implementation on [1], it was requested to extend the Cinder
client to support the newly created microversion (MV). Therefore, this
patch is doing exactly that.
We do not need to do any other work forward bcause the list volumes
will display whatever we have in the response. I mean, the default is
``['ID', 'Status', 'Name', 'Size', 'Volume Type', 'Bootable',
'Attached to']``, but one can customize these fields using ``--fields``
[1] https://review.opendev.org/c/openstack/cinder/+/666886
Closes-Bug: https://bugs.launchpad.net/python-cinderclient/+bug/1913474
Depends-on: https://review.opendev.org/c/openstack/cinder/+/666886
Change-Id: I0815570a50e9b38fe18733c727acd52a406bfc1e
Enhance the 'backup-restore' shell command to support restoring a
backup to a newly created volume of a specific volume type and/or in a
different AZ. New '--volume-type' and '--availability-zone' arguments
leverage the existing cinder API's ability to create a volume from a
backup, which was added in microversion v3.47.
The shell code is a new v3 implementation, and it drops support for the
v2 command's deprecated '--volume-id' argument.
Change-Id: Ic6645d3b973f8487903c5f57e936ba3b4b3bf005
Sync the versions with cinder's, which were recently updated by
I42af21b1c4247d04d479f1fc1ecd6f9baac0cfc9. Also increased the
minimum version of tempest to the most recent release.
Also added indirect dependencies to test-requirements.txt in order
to limit the number of versions considered by the resolver.
Change-Id: I7b4bc7b392b2192e0c832c4f0148546a5920b9e2
Using the cinderclient without a subcommand while
passing an optional argument triggers the raw Python
error `ERROR: 'Namespace' object has no attribute
'func'`. This bug can be reproduced by issuing the
command `cinder --os-volume-api-version 3.40`.
Added a default value to `func` and an empty value to
`command` as placeholders so that a help message is
shown instead of the Python error.
Change-Id: Idb51e8635b97f0da2976f3268d5e19100ec77203
Closes-Bug: #1867061
