DrJava Legacy SVN Repository

This revision fixes a concurrency bug (unexpected deadline of the GUI)
that I introduced in my last two commits when I tried to improve
_wrappedPosList synchronziation in DefinitionsDocument.

I also continued to try elimnate the sprurious "Stepping ..." strings
printed by the debugStepTimer.

The following files were modified:

M src/edu/rice/cs/drjava/model/cache/DocumentCache.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/repl/newjvm/InterpreterJVM.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/util/docnavigation/AWTContainerNavigatorFactory.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigator.java
M src/edu/rice/cs/util/JoinInputStream.java
M src/edu/rice/cs/util/newjvm/AbstractSlaveJVM.java

This revision cleans up some the test code by moving testing operations involving AWT/Swing components to the event thread and eliminating clearEventQueue() calls. Much remains to be done.

The following files were modified:

M src/edu/rice/cs/drjava/DrJavaTestCase.java
M src/edu/rice/cs/drjava/ConfigFileTest.java
M src/edu/rice/cs/drjava/model/debug/jpda/DebugContextTest.java
M src/edu/rice/cs/drjava/model/GlobalModelCompileSuccessTest.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocumentTest.java
M src/edu/rice/cs/drjava/model/definitions/IndentTest.java
M src/edu/rice/cs/drjava/model/GlobalModelCompileSuccessOptionsTest.java
M src/edu/rice/cs/drjava/model/FindReplaceMachineTest.java
M src/edu/rice/cs/drjava/model/junit/JUnitErrorModelTest.java
M src/edu/rice/cs/drjava/model/repl/HistoryTest.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDJDocumentTest.java
M src/edu/rice/cs/drjava/model/repl/InteractionsModelTest.java
M src/edu/rice/cs/drjava/model/GlobalModelOtherTest.java
M src/edu/rice/cs/util/text/SwingDocument.java
M src/edu/rice/cs/util/swing/UtilitiesTest.java
M src/edu/rice/cs/util/swing/Utilities.java

This revision corrects some thread interference (synchronization
protocol) errors in DefaultJUnitErrorModel and assorted small
stylistic and formatting issues in other files.

The following files were modified:

M src/edu/rice/cs/drjava/DrJava.java
M src/edu/rice/cs/drjava/model/debug/jpda/JPDADebugger.java
M src/edu/rice/cs/drjava/model/GlobalModelTestCase.java
M src/edu/rice/cs/drjava/model/cache/DocumentCache.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/junit/DefaultJUnitModel.java
M src/edu/rice/cs/drjava/model/compiler/DefaultCompilerModel.java
M src/edu/rice/cs/drjava/RemoteControlClient.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/TabbedPanel.java
M src/edu/rice/cs/drjava/ui/AbstractDJPane.java
M src/edu/rice/cs/drjava/ui/ReverseHighlighter.java
M src/edu/rice/cs/util/text/SwingDocument.java
M src/edu/rice/cs/util/docnavigation/JListSortNavigator.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigator.java
M src/edu/rice/cs/util/swing/ScrollableListSelectionDialog.java
M src/edu/rice/cs/util/JoinInputStream.java
M src/edu/rice/cs/util/InputStreamRedirector.java
M src/edu/rice/cs/util/newjvm/IntegratedMasterSlaveTest.java

This revision cleans up the behavior of the debugger when LL files are involved. The new code maps source file locations
with no corresponding LL location to -1. A scrolling routine had to be modified to avoid a null pointer exception because -1
corresponds to an invalid offset in the corresponding LL source file. The modified routine simply screens the scrolling
action with a test on the target offset (it must be >= 0).

Many of the edits in this revision were reformatting edits that do not affect program behavior.

The following files were modified:

M src/edu/rice/cs/drjava/model/debug/DebugEventNotifier.java
M src/edu/rice/cs/drjava/model/debug/jpda/JPDADebugger.java
M src/edu/rice/cs/drjava/model/debug/jpda/EventHandlerThread.java
M src/edu/rice/cs/drjava/model/debug/jpda/PendingRequestManager.java
M src/edu/rice/cs/drjava/model/debug/jpda/JPDABreakpoint.java
M src/edu/rice/cs/drjava/model/debug/jpda/JPDAStackData.java
M src/edu/rice/cs/drjava/model/compiler/DefaultCompilerModel.java
M src/edu/rice/cs/drjava/model/compiler/LanguageLevelStackTraceMapper.java
M src/edu/rice/cs/drjava/ui/MainFrame.java

This revision moves a reference to the main Font object out of the
DefinitionsPane, to prevent memory leaks and allow the
DefinitionsPaneMemoryLeakTest to pass. The listener is now in
MainFrame, and a static character width field is kept for all
DefinitionsPanes; that is acceptable, though, because DrJava only
allows one main font for all panes anyway.

This commit marks more potentially shared fields with the "volatile"
attribute and cleans up the naming of variables in
DefinitionsPane.java.

The following files were modified:

M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/util/ReaderWriterLockTest.java
M src/edu/rice/cs/util/ReaderWriterLock.java

This commit adds the volatile modifier to some naked (neither volatile or final) fields of potentially shared classes. It also cleans up
formatting in a few places.

The following files were modified:

M src/edu/rice/cs/drjava/model/debug/jpda/JPDADebugger.java
M src/edu/rice/cs/drjava/model/DJError.java
M src/edu/rice/cs/drjava/model/GlobalModelTestCase.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/BraceTest.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsEditorKit.java
M src/edu/rice/cs/drjava/model/junit/DefaultJUnitModel.java
M src/edu/rice/cs/drjava/model/junit/JUnitError.java
M src/edu/rice/cs/drjava/model/junit/JUnitErrorModel.java
M src/edu/rice/cs/drjava/model/junit/JUnitErrorModelTest.java
M src/edu/rice/cs/drjava/model/repl/HistoryTest.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDJDocument.java
M src/edu/rice/cs/drjava/model/compiler/DefaultCompilerModel.java
M src/edu/rice/cs/drjava/model/compiler/CompilerErrorModel.java
M src/edu/rice/cs/drjava/model/compiler/LanguageLevelStackTraceMapper.java
M src/edu/rice/cs/drjava/model/DummyGlobalModel.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/config/ConfigOptionListeners.java
M src/edu/rice/cs/drjava/config/RecursiveFileListPropertyTest.java
M src/edu/rice/cs/drjava/project/ProjectProfile.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/CompilerErrorPanel.java
M src/edu/rice/cs/drjava/ui/InteractionsPane.java
M src/edu/rice/cs/drjava/ui/TabbedPanel.java
M src/edu/rice/cs/drjava/ui/JarOptionsDialog.java
M src/edu/rice/cs/drjava/ui/ErrorPanel.java
M src/edu/rice/cs/drjava/ui/config/ConfigFrame.java
M src/edu/rice/cs/drjava/ui/config/ConfigPanel.java
M src/edu/rice/cs/drjava/ui/InteractionsPaneTest.java
M src/edu/rice/cs/drjava/ui/JUnitPanel.java
M src/edu/rice/cs/drjava/ui/DrJavaErrorHandler.java
M src/edu/rice/cs/util/FileOps.java
M src/edu/rice/cs/util/docnavigation/JListNavigator.java
M src/edu/rice/cs/util/docnavigation/GroupNode.java
M src/edu/rice/cs/util/docnavigation/FileNode.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigatorTest.java
M src/edu/rice/cs/util/swing/CenteredIcon.java
M src/edu/rice/cs/util/swing/LayeredIcon.java
M src/edu/rice/cs/util/swing/DropDownButton.java
M src/edu/rice/cs/util/sexp/Tokens.java
M src/edu/rice/cs/util/sexp/NumberAtom.java
M src/edu/rice/cs/util/BalancingStreamTokenizerTest.java

Fixing bug 3388371: Right margin is not visible

Font width was wrong.

M drjava/src/edu/rice/cs/drjava/ui/DefinitionsPane.java

This revision cleans up the test code associated with
JUnitErrorModelTest, which hangs about half of the time on a dual core
Linux machine. The revised version will still hang if multiple
JUnitErrorModelTest executions are run back to back. Evidently, a new
test can start before the preceding completely cleans up.

The following files were modified:

M src/edu/rice/cs/drjava/model/GlobalModelTestCase.java
M src/edu/rice/cs/drjava/model/cache/DocumentCache.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelComment.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/AbstractReducedModel.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelBrace.java
M src/edu/rice/cs/drjava/model/junit/JUnitErrorModelTest.java
M src/edu/rice/cs/drjava/model/junit/JUnitTestManager.java

Java 7 support in DrJava. Removed plenty of new warnings.
ConcJUnit is currently incompatible with Java 7, had to be disabled for now.