DrJava Legacy SVN Repository

Includes a work-around for bug 2813140:
Cannot enter braces { } on Icelandic Mac OS X

Additional bad usage of Utilities.clearEventQueue (did't catch this before because this code only runs based on the time since last check). MainFrame constructs a NewVersionPopup in the event thread (MainFrame 3558); the NewVersionPopup constructor then calls clearEventQueue().

Fix for nontermination in GlobalModelCompileErrorsTest. Utilities.clearEventQueue() is being called and successfully running *from* the event queue, violating the implied semantics and raising the possibility that the method will loop infinitely within the event thread waiting for the queue to empty itself.

The fix for clearEventQueue() is to use the Swing invokeAndWait method which throws an exception if run from the event thread. This converts the intermittent failure to a hard failure; the *temporary* fix for code that then consistently fails is to comment out calls to clearEventQueue(). However, this may lead to regressions of other intermittent failures, and a better solution is probably needed.

Specific code that needs to be addressed:
ColoringGlyphPainter, line 333
GlobalModelTestCase, line 658

(This commit also contains some cleanup in response to various Eclipse compiler warnings, such as invalid javadoc code and use of raw types.)

DynamicJava: Updated plt.jar.

PLT Utilities: Bug fixes. Added IncrementalTaskController.doResume(), separating this behavior from doStart(), where ExecutorIncrementalTaskController was distinguishing between the two cases by checking concurrently-changing state. Removed ListenerSet.Sink.retainAll(), which allowed clients to remove other listeners from the set (conflicting with the class's stated purpose).

Touched by dlsmith

Improved browse-forward and browse-back.

PLT: Bug in implementation of AbstractPredicateSet.

Revised JarJDKToolsLibrary.java javac search protocol to look in
/usr/lib/jvm/java* directories where Linux Java JDK packages are
installed. Also made some small changes to GlobalModelJUnitTest because
the DrJava appeared to be hanging in this file, but the hanging problem
was erratic (appearing in other GlobalModelxxTest files) and
spontaneously disappeared.

The following file were modified:
M src/edu/rice/cs/drjava/model/JarJDKToolsLibrary.java
M src/edu/rice/cs/drjava/model/GlobalModelJUnitTest.java

Touched by rcartwright