DrJava Legacy SVN Repository

This revision refactors the Swing component initialization (in setUp)
in several unit tests. This initialization must run in the event
thread because the event thread is typically already running when the
setUp() method for a unit test method is invoked. (A fresh JVM is NOT
started for every test method invocation.)

The following files were modified:

M src/edu/rice/cs/drjava/model/repl/InteractionsDJDocumentTest.java
M src/edu/rice/cs/drjava/CommandLineTest.java
M src/edu/rice/cs/drjava/ui/ProjectMenuTest.java
M src/edu/rice/cs/drjava/ui/MainFrameTest.java

This revision eliminates redundancy in some assert statement predicates (the redundancy was created by performing a global replace command).

The following files were modified:

M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/util/text/ConsoleDocument.java
M src/edu/rice/cs/util/text/SwingDocument.java

This revision fixes a bug in unit testing support in DrJava that was
introduced in build 4573 when unit testing was refactored to cope with
the revised synchronization protocol (running all operations on Swing
documents in the event thread instead of using readers and writers
locking. The bug(s) was(were) created by listener notification code
that was not running in the event thread. This revision moves
essentially all listener notification to the event thread. It also
includes some optimizations to the updating of RegionsTreePanels
(e.g., FindResultsPanels) when documents are edited.

After listener notification was cleaned, a few unit tests (notably
GlobalModelCompileSuccessTest and JUnitErrorModelTest) failed because
they were tuned to vagaries of broken listener notification.

The following files were modified.

M src/edu/rice/cs/drjava/model/BrowserHistoryManager.java
M src/edu/rice/cs/drjava/model/debug/jpda/JPDADebugger.java
M src/edu/rice/cs/drjava/model/GlobalModelTestCase.java
M src/edu/rice/cs/drjava/model/GlobalModelCompileSuccessTest.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/junit/DefaultJUnitModel.java
M src/edu/rice/cs/drjava/model/junit/JUnitErrorModelTest.java
M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/model/compiler/DefaultCompilerModel.java
M src/edu/rice/cs/drjava/model/FindReplaceMachine.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/BrowserDocumentRegion.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/ErrorPanel.java
M src/edu/rice/cs/drjava/ui/BreakpointsPanel.java
M src/edu/rice/cs/drjava/ui/LineEnumRule.java
M src/edu/rice/cs/drjava/ui/JUnitPanel.java
M src/edu/rice/cs/util/text/ConsoleDocument.java
M src/edu/rice/cs/util/text/SwingDocument.java
M src/edu/rice/cs/util/docnavigation/JListNavigator.java
M src/edu/rice/cs/util/docnavigation/IDocumentNavigator.java
M src/edu/rice/cs/util/docnavigation/JListSortNavigatorTest.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigator.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigatorTest.java

Created tag drjava-stable-20080828-r4664

Updated DynamicJava with a number of bug fixes, including support for interface and enum declarations. Removed accessibility option check box from Preferences pending an implementation of accessibility checking. Caught Unicode-escape-related errors occuring when the DynamicJava parser is used to extract a package name.

DynamicJava: A number of bug fixes/missing feature implementations.
- Added support for interface declarations
- Fixed handling of enum declarations
- Simplified generated enum implementation code
- Fixed text of bad allocation type error
- Converted exceptions thrown for unimplemented features to standard errors with a "not implemented" error message
- Restored support for class/instance initializers, which had been broken
- Checks consistency of "abstract" flag and method body
- Fixed NullPointerException arising from attempting to process the body of an abstract method
- Fixed handling of array return types in compiled class declarations
- Fixed environments so that a class's name is visible in its body

This revision makes the creation of tooltips for items in RegionTreePanels
lazy. It should avert most of the long delays that we have seen when
pasting and undoing while Find Results are being displayed and updated.

M src/edu/rice/cs/drjava/ui/RegionsTreePanel.java

This revision encloses the setUp code for DefinitionsPaneTest in
Utilities.invokeAndWait. This test was occasionally failing during
setUp in various test methods. The failures involved operations on
the created MainFrame. Since unit test are run in an JVM that has run
prior tests, the event thread is already activated which makes running
intitialization code outside the event thread problematic.

Only the following file was modified:

M src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java

This commit refactors the method testTypeEnterNotInCode in
DefinitionsPaneTest to confirm with the "event thread only"
pre-conditions in calls to Swing methods. It also re-enables checking
of for DefinitionsPane leaks in the method testDocumentPaneMemoryLeak.
(This method checks for both DefintionsPane leaks and
DefinitionsDocument leaks; the former had been disabled sometime
during the past summer because it had been inexplicably failing but
was not causing problems in practice.) This commit also subsitutes
ArrayList objects for LinkedList objects in two files in an attempt
to streamline the code.

The following files were modified:

M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java
M src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java

This commit comments out a debugging print stateent that I
inadvertently left in a recent commit. It also includes a few
cosmetic improvements to code commenting and formatting.

The following files were modified:

M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/RegionsTreePanel.java