DrJava Legacy SVN Repository

This revision deletes IDocList.java which is no longer used.

This revision changes to interface to the IDocumentNavigator interface
and its implementation. Previously, the getDocuments() and
getDocumentsInBin() methods returned Enumerations which appeared to be
backed by the document list maintained in the navigator. The revised
operations return ArrayList copies of relevant lists of documents.

This revision also includes some additional conversions of Vectors to
ArrayLists.

The following files were modified:

M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/util/docnavigation/JListNavigator.java
M src/edu/rice/cs/util/docnavigation/AWTContainerNavigatorFactory.java
M src/edu/rice/cs/util/docnavigation/IDocList.java
M src/edu/rice/cs/util/docnavigation/IDocumentNavigator.java
M src/edu/rice/cs/util/docnavigation/JListSortNavigatorTest.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigator.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigatorTest.java

This revision converts some occurrences of Vector to ArrayList.

The following files were changed:

M src/edu/rice/cs/drjava/model/debug/NoDebuggerAvailable.java
M src/edu/rice/cs/drjava/model/debug/Debugger.java
M src/edu/rice/cs/drjava/model/debug/jpda/JPDADebugger.java
M src/edu/rice/cs/drjava/model/debug/jpda/DebugContextTest.java
M src/edu/rice/cs/drjava/model/debug/jpda/JPDABreakpoint.java
M src/edu/rice/cs/drjava/model/definitions/indent/IndentRuleWithTraceTest.java
M src/edu/rice/cs/drjava/model/definitions/indent/IndentRuleWithTrace.java
M src/edu/rice/cs/drjava/ui/DebugPanel.java
M src/edu/rice/cs/drjava/ui/BrowserHistoryPanel.java
M src/edu/rice/cs/drjava/ui/BreakpointsPanel.java
M src/edu/rice/cs/drjava/ui/BookmarksPanel.java

Disable the Plastic LAFs for the Mac platform.

This revions contains some minor cleanup code like deleting print
statements inserted for debugging and converting instances of Vector
to ArrayList. The following files were modified:

M src/edu/rice/cs/drjava/model/BrowserHistoryManager.java
M src/edu/rice/cs/drjava/model/debug/jpda/PendingRequestManager.java
M src/edu/rice/cs/drjava/model/GlobalModel.java
M src/edu/rice/cs/drjava/model/cache/DocumentCacheTest.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocumentTest.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelControl.java
M src/edu/rice/cs/drjava/model/RegionManager.java
M src/edu/rice/cs/drjava/model/repl/History.java
M src/edu/rice/cs/drjava/model/repl/newjvm/InterpreterJVM.java
M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java
M src/edu/rice/cs/drjava/model/Query.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/model/DocumentRegion.java
M src/edu/rice/cs/drjava/model/DummyGlobalModel.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/DefaultLightWeightParsingControl.java
M src/edu/rice/cs/drjava/model/GlobalModelOtherTest.java
M src/edu/rice/cs/drjava/config/KeyStrokeOption.java
M src/edu/rice/cs/drjava/config/OptionParser.java
M src/edu/rice/cs/drjava/config/Option.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/InteractionsPane.java
M src/edu/rice/cs/drjava/ui/RecentFileManager.java
M src/edu/rice/cs/drjava/ui/KeyBindingManager.java
M src/edu/rice/cs/drjava/ui/HTMLFrame.java
M src/edu/rice/cs/drjava/ui/ErrorPanel.java
M src/edu/rice/cs/drjava/ui/BrowserHistoryPanel.java
M src/edu/rice/cs/drjava/ui/config/ConfigFrame.java
M src/edu/rice/cs/drjava/ui/config/KeyStrokeOptionComponent.java
M src/edu/rice/cs/drjava/ui/InsertVariableDialog.java
M src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java
M src/edu/rice/cs/drjava/ui/ReverseHighlighter.java
M src/edu/rice/cs/drjava/ui/ProjectPropertiesFrame.java
M src/edu/rice/cs/util/FileOps.java
M src/edu/rice/cs/util/text/SwingDocument.java
M src/edu/rice/cs/util/OrderedHashSet.java
M src/edu/rice/cs/util/swing/HighlightManager.java
M src/edu/rice/cs/util/NullFile.java
M src/edu/rice/cs/util/sexp/Tokens.java

Removed some debug messages.

This revision fixes several bugs in the implementation of regions,
region managers, and the interaction between DrJava and the Plastic
L&F. This revision modifies the JTree renderer in FindResultsPanel so
that the "reverse video" display of a selected node in the Plastic L&F
works.

The revision also corrects a serious design problem with the
DocumentRegion class and its descendants. DocumentRegion defines
compareTo and overrides equals so that regions are lexicographically
ordered by the offsets of their two positions. The overriding of
equals makes it agree with the equivalence defined by compareTo. The
compareTo operation (from the Comparable interface) is used in
TreeSets of DocumentRegions in ConcreteRegionManager. By using the
Comparable ordering and TreeSets, the cost of insertion, removal, and
membership testing for TreeSets is reduced to O(log N), which is
important in FindAll searches with many matches in a single document.
But the corresponding view classes, namely RegionsTreePanel and
FindResultsPanel among others, rely on hash tables that use regions as
keys. Since positions in regions can move, a definition of hashCode
that is consistent with equals is disastrous; it breaks hash tales
that use regions as keys because region hash codes change as the
document is edited.

In this revision, hashCode is NOT overriden in DocumentRegion or any
of its descendants and IdentiyHashMaps are used instead of Hashtables
so that the overridden equals does not break hash table operation.
Note that merely avoiding the override of hashCode is insufficient
because the overridden definition of equals can break hash table
operations in some cases (distinct regions become equal if
their offsets coincide after editing).

The following files were modified:

M src/edu/rice/cs/drjava/IndentFiles.java
M src/edu/rice/cs/drjava/model/RegionManager.java
M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java
M src/edu/rice/cs/drjava/model/DocumentRegion.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/BrowserDocumentRegion.java
M src/edu/rice/cs/drjava/model/OpenDefinitionsDocument.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/TabbedPanel.java
M src/edu/rice/cs/drjava/ui/DebugPanel.java
M src/edu/rice/cs/drjava/ui/MainFrameTest.java
M src/edu/rice/cs/drjava/ui/RegionsTreePanel.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java
M src/edu/rice/cs/drjava/ui/JUnitPanel.java

This revision eliminates HTML-based color highlighting in
FindResultsPanel entries and uses unicode solid circle markers as
delimiters instead. It also cleans up the padding of entry text with
blanks to support subsequent editing.

The following files were modified:

M src/edu/rice/cs/drjava/DrJava.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/repl/InteractionsScriptModel.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDJDocument.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/RegionsTreePanel.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java
M src/edu/rice/cs/util/text/ConsoleDocument.java
M src/edu/rice/cs/util/StringOps.java

Removed support for winlaf. It is no longer necessary, and we're not sure it works.

Warn the user that theme changes will not take effect until restart.
Add option to toggle this warning on/off.