DrJava Legacy SVN Repository

PLT Utilities: Fixed typo.

PLT Utilities: Added ComposedListeners to the Swing package.

Adding calls to setChanging back to improve speed of turning "Find All"
results into bookmarks, of removing results and closing "Find All"
panes.

M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java

This revision fixes assorted bugs in the recent refactoring of regions
and a lingering bug in the implementation of FindResults table of
highlight managers. The table was implemented as a Hashtable mapping
document regions to HighlightInfo records. But document regions are
mutable because they can move within a document (just like Positions), so
table lookups failed if the coordinates of the region changed due to
document mutation.

This revision conflicts with the last two updates because it fixes
many of the same problems without sacrificing the efficiency of new
region implementation. This revision reverts the bookmark tests (in
GlobalModelOtherTest.java) back to their former state. We need to add
some unit tests that address the movement of regions when documents
are modified.

The following files were modified, primarily ConcreteRegionManager and
MainFrame:

M src/edu/rice/cs/drjava/model/debug/jpda/JPDADebugger.java
M src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
M src/edu/rice/cs/drjava/model/definitions/indent/Indenter.java
M src/edu/rice/cs/drjava/model/RegionManager.java
M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/GlobalModelOtherTest.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/TabbedPanel.java
M src/edu/rice/cs/drjava/ui/RegionsTreePanel.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java
M src/edu/rice/cs/drjava/ui/ReverseHighlighter.java
M src/edu/rice/cs/util/swing/HighlightManager.java
M src/edu/rice/cs/util/CompletionMonitor.java

Fixes a problem with the optimized "Find All"; now the file
nodes are expanded after the search has finished.

Fixes [ 1959032 ] "New Project" incorrect about existing file

Fixed [ 1968728 ] Difficulty Removing Breakpoints and Bookmarks
https://sourceforge.net/tracker/index.php?func=detail&aid=1968728&group_id=44253&atid=438935
The previously criticized performance problems when finding an
overlapping region have been avoided: Instead of scanning the entire
ordered set of regions for a document, only the regions between the
first and the last line of the region to be toggled (added/removed)
are considered. This has been efficiently achieved by getting the
headSet of the tailSet of regions.

Fixes bug report
[ 1967938 ] Find All Highlights Never Removed
https://sourceforge.net/tracker/?func=detail&atid=438935&aid=1967938&group_id=44253
In revision 4482, a loop calling removeRegion for every
region removed by clearRegions() and removeRegions(OpenDefinitionsDocument)
was removed and replaced by a simple call to clear() of the underlying
data structure. This did not notify the listeners anymore that regions
were removed, causing the highlights never to be removed.

M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java

PLT Utilities: Fixed typo in FileLog which left a constructor commented out. Added "relax" methods to IterUtil for situations in which wildcards aren't convenient.

This revision adds document read locking to the overridden definition
of drawUnslectedText in the ColoringView class extending PlainView.
It is not clear that the swing library code always calls this method
with the read lock already held. The overridden method does not require
this locking because it only makes a single class to getText(...) to access
the document and this method performs read locking.

The following files were modified.

M src/edu/rice/cs/drjava/model/definitions/ColoringView.java
M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java

The other two files were only revised cosmetically (formatting not code).