DrJava Legacy SVN Repository

This revision fixes assorted bugs in the recent refactoring of regions
and a lingering bug in the implementation of FindResults table of
highlight managers. The table was implemented as a Hashtable mapping
document regions to HighlightInfo records. But document regions are
mutable because they can move within a document (just like Positions), so
table lookups failed if the coordinates of the region changed due to
document mutation.

This revision conflicts with the last two updates because it fixes
many of the same problems without sacrificing the efficiency of new
region implementation. This revision reverts the bookmark tests (in
GlobalModelOtherTest.java) back to their former state. We need to add
some unit tests that address the movement of regions when documents
are modified.

The following files were modified, primarily ConcreteRegionManager and
MainFrame:

M src/edu/rice/cs/drjava/model/debug/jpda/JPDADebugger.java
M src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
M src/edu/rice/cs/drjava/model/definitions/indent/Indenter.java
M src/edu/rice/cs/drjava/model/RegionManager.java
M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/GlobalModelOtherTest.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/TabbedPanel.java
M src/edu/rice/cs/drjava/ui/RegionsTreePanel.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java
M src/edu/rice/cs/drjava/ui/ReverseHighlighter.java
M src/edu/rice/cs/util/swing/HighlightManager.java
M src/edu/rice/cs/util/CompletionMonitor.java

Fixes a problem with the optimized "Find All"; now the file
nodes are expanded after the search has finished.

Fixes [ 1959032 ] "New Project" incorrect about existing file

Fixed [ 1968728 ] Difficulty Removing Breakpoints and Bookmarks
https://sourceforge.net/tracker/index.php?func=detail&aid=1968728&group_id=44253&atid=438935
The previously criticized performance problems when finding an
overlapping region have been avoided: Instead of scanning the entire
ordered set of regions for a document, only the regions between the
first and the last line of the region to be toggled (added/removed)
are considered. This has been efficiently achieved by getting the
headSet of the tailSet of regions.

Fixes bug report
[ 1967938 ] Find All Highlights Never Removed
https://sourceforge.net/tracker/?func=detail&atid=438935&aid=1967938&group_id=44253
In revision 4482, a loop calling removeRegion for every
region removed by clearRegions() and removeRegions(OpenDefinitionsDocument)
was removed and replaced by a simple call to clear() of the underlying
data structure. This did not notify the listeners anymore that regions
were removed, causing the highlights never to be removed.

M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java

PLT Utilities: Fixed typo in FileLog which left a constructor commented out. Added "relax" methods to IterUtil for situations in which wildcards aren't convenient.

This revision adds document read locking to the overridden definition
of drawUnslectedText in the ColoringView class extending PlainView.
It is not clear that the swing library code always calls this method
with the read lock already held. The overridden method does not require
this locking because it only makes a single class to getText(...) to access
the document and this method performs read locking.

The following files were modified.

M src/edu/rice/cs/drjava/model/definitions/ColoringView.java
M src/edu/rice/cs/drjava/model/ConcreteRegionManager.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java

The other two files were only revised cosmetically (formatting not code).

This commit allows the user to double-click on a word in the
"Execute External Process" pane, and if it happens to be a
file name, perhaps followed by a colon and a line number,
then the definitions pane will display that file and jump
to the specified line number. This helps with compilng
files using an external compiler, such as javac, NextGen
or xajavac, and then correcting the errors reported by the
compilers.

A change was made to the way file names are saved in
project files: Even though we created a file name that was
relative to the project root, because we used the File
class, this file name was turned into an absolute path
in the project file. Now file names are treated as strings
and are now finally relative to the project root, and
not absolute.

Added catch statements to deal with a StringIndexOutOfBoundsException
[ 1967750 ] Some error with something....?
https://sourceforge.net/tracker/?func=detail&atid=438935&aid=1967750&group_id=44253

This revions refactors the implementation and interfaces of document
regions to support more efficient construction of the FindAll panels
in the FindAll command. The old implementation was very slow for
searches with many matches. The following files were
added/deleted/modified:

M src/edu/rice/cs/drjava/model/DummyGlobalModelListener.java
M src/edu/rice/cs/drjava/model/debug/DebugWatchData.java
M src/edu/rice/cs/drjava/model/debug/Debugger.java
M src/edu/rice/cs/drjava/model/debug/DebugListener.java
M src/edu/rice/cs/drjava/model/debug/jpda/PendingRequestManager.java
M src/edu/rice/cs/drjava/model/debug/jpda/JPDABreakpoint.java
M src/edu/rice/cs/drjava/model/debug/Breakpoint.java
M src/edu/rice/cs/drjava/model/GlobalModelTestCase.java
M src/edu/rice/cs/drjava/model/GlobalModel.java
M src/edu/rice/cs/drjava/model/DocumentRegionTest.java
M src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
D src/edu/rice/cs/drjava/model/StaticDocumentRegion.java
M src/edu/rice/cs/drjava/model/DummyDocumentRegion.java
M src/edu/rice/cs/drjava/model/MovingDocumentRegion.java
M src/edu/rice/cs/drjava/model/GlobalEventNotifier.java
D src/edu/rice/cs/drjava/model/EnhancedDocumentRegion.java
M src/edu/rice/cs/drjava/model/RegionManager.java
M src/edu/rice/cs/drjava/model/GlobalModelListener.java
D src/edu/rice/cs/drjava/model/SimpleDocumentRegion.java
A src/edu/rice/cs/drjava/model/ConcreteRegionManager.java
M src/edu/rice/cs/drjava/model/DocumentRegion.java
M src/edu/rice/cs/drjava/model/DummyOpenDefDoc.java
M src/edu/rice/cs/drjava/model/RegionManagerListener.java
M src/edu/rice/cs/drjava/model/DummyGlobalModel.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/DefaultLightWeightParsingControl.java
M src/edu/rice/cs/drjava/model/GlobalModelOtherTest.java
A src/edu/rice/cs/drjava/model/Region.java
M src/edu/rice/cs/drjava/model/BrowserDocumentRegion.java
A src/edu/rice/cs/drjava/model/OrderedDocumentRegion.java
A src/edu/rice/cs/drjava/model/IDocumentRegion.java
M src/edu/rice/cs/drjava/model/OpenDefinitionsDocument.java
M src/edu/rice/cs/drjava/project/ProjectFileIR.java
M src/edu/rice/cs/drjava/project/ProjectFileParser.java
M src/edu/rice/cs/drjava/project/XMLProjectFileParser.java
M src/edu/rice/cs/drjava/project/DocFile.java
M src/edu/rice/cs/drjava/project/ProjectFileParserFacade.java
M src/edu/rice/cs/drjava/project/ProjectProfile.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/ErrorPanel.java
M src/edu/rice/cs/drjava/ui/BreakpointsPanel.java
M src/edu/rice/cs/drjava/ui/RegionsTreePanel.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java
M src/edu/rice/cs/drjava/ui/RegionsListPanel.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java
M src/edu/rice/cs/drjava/ui/BookmarksPanel.java
M src/edu/rice/cs/util/NullFile.java

Addresses bug report [ 1962520 ] NullPointerException
http://sourceforge.net/tracker/index.php?func=detail&aid=1962520&group_id=44253&atid=438935

This is due to an unfixed Java bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5085515

Could not verify, but according to the work-around on the
Sun database, this should help.