DrJava Legacy SVN Repository

Added test for getParentFile()==null in FileOps.

This commit cleans up some initialization issues (bugs) with the
tabbed pane, most (all?) of which were introduced in the last commit .
The following files were modified:

M src/edu/rice/cs/drjava/DrJavaRoot.java
M src/edu/rice/cs/drjava/model/JDKToolsLibrary.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/TabbedPanel.java
M src/edu/rice/cs/drjava/ui/AbstractConsoleController.java

This commit fixes some minor GUI focus bugs involving the interactions and navigations panes. The following files were modified:

M src/edu/rice/cs/drjava/model/DummyGlobalModelListener.java
M src/edu/rice/cs/drjava/model/GlobalModelTestCase.java
M src/edu/rice/cs/drjava/model/GlobalEventNotifier.java
M src/edu/rice/cs/drjava/model/GlobalModelListener.java
M src/edu/rice/cs/drjava/model/SingleDisplayModelTest.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/TabbedPanel.java
M src/edu/rice/cs/drjava/ui/predictive/PredictiveInputFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java
M src/edu/rice/cs/drjava/ui/RecentDocFrame.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java
M src/edu/rice/cs/drjava/ui/ClipboardHistoryFrame.java
M src/edu/rice/cs/util/docnavigation/JListNavigator.java
M src/edu/rice/cs/util/docnavigation/JListSortNavigator.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigator.java

Fix for SF support request #1689411, I hope. I cannot reproduce the error, but I have a test.

Fixes bug [ 1696060 ] Debugger Infinite Loop.

The deadlock was a result of the debugger thread, already owning the
lock of the debugger, asking the global model to open a file, so
setActiveDocument put code on the event queue. When this code
executed, the event thread tried to call a synchronized method of the
debugger, but never managed to acquire it, because the debugger thread
already owned it.

I changed the code to have the debugger thread
"preload" a document every time a step is made, before claiming the
debugger lock. This brings setActiveDocument into action and the
document is opened if necessary. Then the debugger lock is claimed and
the response to the step is made.

M src/edu/rice/cs/drjava/model/debug/jpda/JPDADebugger.java
M src/edu/rice/cs/drjava/model/debug/jpda/EventHandlerThread.java

Fixed Java5 compilation problem wrt. @Override on interface method implementations.

Added ScrollableListSelectionDialog. Updated JavaDoc in ScrollableListDialog.

Fixed a long-standing bug that involved DrJava highlights taking precedence over selected text highlighting. This was fixed by enforcing an ordering on the highlights by an insert-in-order operation when a highlight is added. The ordering is as follows (from most important to least):
DefaultUnderlineHighlightPainter (used for underlines as in find all)
DefaultFrameHighlightPainter (used to draw a box around the highlighted text)
DefaultHighlightPainter (now called only by Swing for a normal highlight)
DrJavaHighlightPainter (a normal highlight requested by DrJava)

The DrJavaHighlightPainter nested class was added in order to differentiate between highlights created by DrJava and those created by Swing (this helps us find the selected text highlight and raise its priority). The insert-in-order operation may cause a slight performance decrease, but is not intended as a long-term solution. Ideally, a better type of storage will be used to make inserting a quicker operation.

M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/ErrorPanel.java
M src/edu/rice/cs/drjava/ui/AbstractDJPane.java
M src/edu/rice/cs/drjava/ui/ReverseHighlighter.java
M src/edu/rice/cs/util/swing/HighlightManagerTest.java

This revision fixes a focus bug in the interactions pane. After
interpreting an interaction that reads from the console (like "new
java.util.Scanner(System.in).nextInt()", DrJava prints the result and
moves the focus to the definitions pane. This revision appears to fix
that problem.

One line in the following file was changed:

M src/edu/rice/cs/drjava/ui/InteractionsController.java

Fixes the NullPointerException in Bug #1689411.