DrJava Legacy SVN Repository

This revision include some small changes in the use of invokeAndWait and synchronized that appear to produce some modest gains in responsiveness. The following files were modified.

M src/edu/rice/cs/drjava/DrJavaRoot.java
M src/edu/rice/cs/drjava/model/cache/DocumentCache.java
M src/edu/rice/cs/drjava/model/definitions/CompoundUndoManager.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelBrace.java
M src/edu/rice/cs/drjava/model/junit/DefaultJUnitModel.java
M src/edu/rice/cs/drjava/model/repl/newjvm/InterpreterJVM.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/model/compiler/DefaultCompilerModel.java
M src/edu/rice/cs/drjava/model/compiler/CompilerModel.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/JarOptionsDialog.java
M src/edu/rice/cs/drjava/ui/PreviewFrame.java
M src/edu/rice/cs/drjava/ui/MainFrameTest.java
M src/edu/rice/cs/drjava/ui/RegionsTreePanel.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java
M src/edu/rice/cs/drjava/ui/InteractionsController.java
M src/edu/rice/cs/drjava/ui/ClipboardHistoryFrame.java
M src/edu/rice/cs/util/swing/HighlightManager.java
M src/edu/rice/cs/util/swing/SwingWorker.java
M src/edu/rice/cs/util/CompletionMonitor.java

Updated compiler interface to support bootclasspath and eliminate needless state

This revision reverses some of the changes made to the overriding of createPostion in DefinitionsDocument. Some of the highlighting support works with arbitrary Documents yet requres Wrapped Postions in DefinitionsDocuments. The definition of createPosition is once again overridden in DefinitionsDocument. A new createUnwrappedPosition method has been added to provide a more efficient alternative to createPostion within DefinitionsDocument. Many minor changes to synchronization are also included in this revision.

Anonymizes user.name, user.dir and user.home in the output
that users submit in bug reports.
M src/edu/rice/cs/drjava/ui/DrJavaErrorWindow.java

Revised the core search method in FindReplaceMachine to use indexOf
and lastIndexOf with offsets instead of repeatedly taking substrings
of the document segment begin searched. This change appears to speed
up searching for strings that have lots of "rejected matches" (not
a whole word, inside a comment, etc.).

Streamlined the locking in JTreeSortNavigator.java and marked all of
its shared fields as final or volatile.l

The following files were revised, much of it cosmetic:

M src/edu/rice/cs/drjava/model/MovingDocumentRegion.java
M src/edu/rice/cs/drjava/model/repl/History.java
M src/edu/rice/cs/drjava/model/repl/InteractionsModelTest.java
M src/edu/rice/cs/drjava/model/SimpleDocumentRegion.java
M src/edu/rice/cs/drjava/model/DocumentRegion.java
M src/edu/rice/cs/drjava/model/FindReplaceMachine.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/util/docnavigation/JListNavigator.java
M src/edu/rice/cs/util/docnavigation/JListSortNavigator.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigator.java

Revised synchronization in DefinitionsPane for operations on
_wrappedPosList by creating a designated private lock object.
Replaced the override of createPosition(...) in DefintionsDocument by
the new method createWrappedPosition and converted calls that created
persistent postions to use this method. Calls on createPostion should
now be lighter weight.

Revised testDefinitionsPaneMemoryLeak in DefinitionsPaneTest to
iterate the GC process until no leak remains, so the test will now
fail by divergins.

The following files were modified:

M src/edu/rice/cs/drjava/model/debug/Breakpoint.java
M src/edu/rice/cs/drjava/model/definitions/DefinitionsDocument.java
M src/edu/rice/cs/drjava/model/RegionManager.java
M src/edu/rice/cs/drjava/model/repl/JavaInterpreterTest.java
M src/edu/rice/cs/drjava/model/repl/JavaInterpreter.java
M src/edu/rice/cs/drjava/model/repl/DynamicJavaAdapter.java
M src/edu/rice/cs/drjava/model/SimpleDocumentRegion.java
M src/edu/rice/cs/drjava/model/DummyOpenDefDoc.java
M src/edu/rice/cs/drjava/model/compiler/CompilerErrorModel.java
M src/edu/rice/cs/drjava/model/FindReplaceMachine.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/OpenDefinitionsDocument.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java
M src/edu/rice/cs/drjava/ui/RegionsListPanel.java
M src/edu/rice/cs/drjava/ui/FindResultsPanel.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java
M src/edu/rice/cs/drjava/ui/BookmarksPanel.java
M src/edu/rice/cs/drjava/ui/SplashScreen.java
M src/edu/rice/cs/drjava/ui/ReverseHighlighter.java
M src/edu/rice/cs/util/swing/DelegatingAction.java
M src/edu/rice/cs/util/swing/CenteredIcon.java
M src/edu/rice/cs/util/swing/DefaultFileDisplayManager.java
M src/edu/rice/cs/util/swing/FileSelectionEvent.java
M src/edu/rice/cs/util/swing/LayeredIcon.java
M src/edu/rice/cs/util/swing/FileDisplayManager.java
M src/edu/rice/cs/util/swing/DisplayManager.java
M src/edu/rice/cs/util/swing/HighlightManagerTest.java
M src/edu/rice/cs/util/swing/UnfocusableButton.java
M src/edu/rice/cs/util/swing/FileDisplay.java
M src/edu/rice/cs/util/swing/Utilities.java
M src/edu/rice/cs/util/swing/DirectoryChooser.java
M src/edu/rice/cs/util/swing/FileSelectionListener.java
M build.xml

Turned on assertion checking in the various ant test script commands.
Added assertions to many methods that only run in the even`qt thread
and adjusted test case code to conform to these assertions. We still
have a long way to do in this arena. Reindented AsyncTask and
CompletionMonitorTest.

The following files were modified; the changes in each file were minor.

M src/edu/rice/cs/drjava/model/debug/DebugEventNotifier.java
M src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/GlobalModelOtherTest.java
M src/edu/rice/cs/drjava/config/KeyStrokeOption.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/DebugPanel.java
M src/edu/rice/cs/drjava/ui/ErrorCaretListener.java
M src/edu/rice/cs/drjava/ui/config/ConfigFrame.java
M src/edu/rice/cs/drjava/ui/ProjectMenuTest.java
M src/edu/rice/cs/drjava/ui/BreakpointsPanel.java
M src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java
M src/edu/rice/cs/drjava/ui/JUnitPanel.java
M src/edu/rice/cs/drjava/ui/ClipboardHistoryFrame.java
M src/edu/rice/cs/util/docnavigation/JListNavigator.java
M src/edu/rice/cs/util/docnavigation/AWTContainerNavigatorFactory.java
M src/edu/rice/cs/util/docnavigation/IDocumentNavigator.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigator.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigatorTest.java
M src/edu/rice/cs/util/swing/AsyncTask.java
M src/edu/rice/cs/util/CompletionMonitorTest.java
M src/edu/rice/cs/util/newjvm/AbstractMasterJVM.java
M build.xml

This revision fixes a bug in RMIInteractionsModel that has been
causing InteractionsDocument errors just after a resetInteractions
action. IT also fixes a bug in console input handling by always
placing a vertical scrollbar in the interactions pane. (The input box
would not resize when the vertical scrollbar was added dynamically
when the number os lines of text exceeded what can be displayed.)
This revision also removes some synchronization and calls on
invokeLater based on the presumption of the invariant that certain
methods only run in the event thread. Some assert statments have been
inserted to this effect, but we should insert more. It appears that
we are not enforcing assert statements in our ant test script, which
needs to be changed.

The following files were modified. As usual, many of the changes were
cosmetic.

M src/edu/rice/cs/drjava/model/GlobalModel.java
M src/edu/rice/cs/drjava/model/cache/DocumentCache.java
M src/edu/rice/cs/drjava/model/cache/DDReconstructor.java
M src/edu/rice/cs/drjava/model/DefaultGlobalModel.java
M src/edu/rice/cs/drjava/model/definitions/indent/IndentRulesTestCase.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/ReducedModelControl.java
M src/edu/rice/cs/drjava/model/definitions/reducedmodel/IndentInfoTest.java
M src/edu/rice/cs/drjava/model/DefaultJavadocModel.java
M src/edu/rice/cs/drjava/model/junit/DefaultJUnitModel.java
M src/edu/rice/cs/drjava/model/repl/InteractionsDJDocument.java
M src/edu/rice/cs/drjava/model/repl/RMIInteractionsModel.java
M src/edu/rice/cs/drjava/model/GlobalModelJUnitTest.java
M src/edu/rice/cs/drjava/model/SimpleDocumentRegion.java
M src/edu/rice/cs/drjava/model/JavadocListener.java
M src/edu/rice/cs/drjava/model/AbstractDJDocument.java
M src/edu/rice/cs/drjava/model/MultiThreadedTestCase.java
M src/edu/rice/cs/drjava/model/compiler/DefaultCompilerModel.java
M src/edu/rice/cs/drjava/model/compiler/CompilerErrorModel.java
M src/edu/rice/cs/drjava/model/DummyGlobalModel.java
M src/edu/rice/cs/drjava/model/AbstractGlobalModel.java
M src/edu/rice/cs/drjava/model/OpenDefinitionsDocument.java
M src/edu/rice/cs/drjava/config/KeyStrokeOptionTest.java
M src/edu/rice/cs/drjava/config/VectorOption.java
M src/edu/rice/cs/drjava/CommandLineTest.java
M src/edu/rice/cs/drjava/ui/MainFrame.java
M src/edu/rice/cs/drjava/ui/CompilerErrorPanel.java
M src/edu/rice/cs/drjava/ui/PreviewConsoleFrame.java
M src/edu/rice/cs/drjava/ui/DefinitionsPane.java
M src/edu/rice/cs/drjava/ui/JarOptionsDialog.java
M src/edu/rice/cs/drjava/ui/ErrorPanel.java
M src/edu/rice/cs/drjava/ui/predictive/PredictiveInputFrame.java
M src/edu/rice/cs/drjava/ui/config/VectorOptionComponent.java
M src/edu/rice/cs/drjava/ui/config/OptionComponent.java
M src/edu/rice/cs/drjava/ui/PreviewFrame.java
M src/edu/rice/cs/drjava/ui/MainFrameTest.java
M src/edu/rice/cs/drjava/ui/PreviewDefDocFrame.java
M src/edu/rice/cs/drjava/ui/JavadocErrorPanel.java
M src/edu/rice/cs/drjava/ui/DefinitionsPaneTest.java
M src/edu/rice/cs/drjava/ui/FindReplacePanel.java
M src/edu/rice/cs/drjava/ui/JUnitPanel.java
M src/edu/rice/cs/drjava/ui/AbstractConsoleController.java
M src/edu/rice/cs/drjava/ui/ClipboardHistoryFrame.java
M src/edu/rice/cs/util/text/ConsoleDocument.java
M src/edu/rice/cs/util/text/SwingDocument.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigator.java
M src/edu/rice/cs/util/docnavigation/JTreeSortNavigatorTest.java
M src/edu/rice/cs/util/swing/ScrollableDialog.java

Added explicit "includes" to filesets. This was causing problems in some versions of Ant.

Created tag drjava-eclipse-20061030-1946